Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #9969 (closed defect: incomplete)

Opened 10 months ago

Last modified 10 months ago

[PATCH] Remove obsolete ActiveSupport::JSON::Variable (and its tests)

Reported by: chuyeow Assigned to: core
Priority: normal Milestone: 2.x
Component: ActiveSupport Version: edge
Severity: normal Keywords:
Cc:

Description

ActiveSupport::JSON::Variable is no longer being used since r7697. This patch removes it and tests for it.

Attachments

remove_obsolete_json_variable.diff (1.6 kB) - added by chuyeow on 10/24/07 09:43:05.

Change History

10/24/07 09:43:05 changed by chuyeow

  • attachment remove_obsolete_json_variable.diff added.

10/24/07 14:25:20 changed by gbuesing

ActiveSupport::JSON::Variable is called by PrototypeHelper's page.literal method: 

def literal(code)
  ActiveSupport::JSON::Variable.new(code.to_s)
end

10/24/07 14:47:17 changed by chuyeow

  • status changed from new to closed.
  • resolution set to incomplete.

Very good point. I believe I forgot to run the tests for ActionPack!

Hmm then it seems useful though from the way it is used in one case in PrototypeHelper the semantics seem to have been abused.

Closing this ticket for now...