Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #9915 (new defect)

Opened 2 years ago

[PATCH]: making label "for" and radio_button "id" more consistent

Reported by: zilkey Assigned to: core
Priority: normal Milestone: 2.x
Component: ActionPack Version: edge
Severity: normal Keywords:
Cc:

Description

This patch:

  • makes radio_button respect the :index option
  • makes label respect the :index option
  • adds test coverage for all form_helper :index behavior
  • adds a :radio_button_value key to label so that it can generate consistent :for attributes for radio_button tags (previously developers had to generate their own :for attributes for labels of radio buttons)
  • adds documentation for the radio_button index and auto_index behavior
  • adds documentation for the new label :radio_button_value key

All actionpack tests pass, but I did not run the active_record_integration tests.

This is my first patch here, and I know that the :radio_button_value is a bit of a stretch. If you want me to rename that key, or remove it from the patch I can.

Also, if there are any stylistic issues I'd be glad to fix them.

Attachments

make_index_consistent_with_radio_buttons_and_labels.diff (10.9 kB) - added by zilkey on 10/18/07 05:45:36.

Change History

10/18/07 05:45:36 changed by zilkey

  • attachment make_index_consistent_with_radio_buttons_and_labels.diff added.