Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #9821 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

[PATCH][TESTS] Stable Actionpack tests fail after clean checkout

Reported by: mikel Assigned to: core
Priority: high Milestone: 1.2.5
Component: ActionPack Version: 1.2.3
Severity: normal Keywords: actionpack
Cc: bitsweat

Description

I checked out stable today to do a patch to acts_as_list.

I ran the tests and got 21 failing tests in Actionpack.

After review, many of these were due to encoding errors. The tests expected < but was returned the C octal UTF \074 etc.

I went through all the tests (10 in total) in prototype_helper_test.rb and javascript_helper_test.rb and swapped out the encodings in the tests.

Additionaly, had to change quotes from " style (including %Q and <<-DOCS to %q and single quotes to avoid Ruby transliterating the octal back into ASCII before doing the test.

All the tests in the above two files pass with this patch.

There are another 13 bugs in AssertSelectTest in 1.2 stable right now which I am unable to find the solution for... any pointers would be great!

Regards

Mikel

Attachments

stable-fixes_to_encoding_tests_in_prototype_and_javascript_helpers.diff (4.9 kB) - added by mikel on 10/08/07 17:00:11.
Makes the failing tests in 1.2 stable back into passing tests for prototype and javascript helpers

Change History

10/08/07 17:00:11 changed by mikel

  • attachment stable-fixes_to_encoding_tests_in_prototype_and_javascript_helpers.diff added.

Makes the failing tests in 1.2 stable back into passing tests for prototype and javascript helpers

10/08/07 20:34:14 changed by bitsweat

  • status changed from new to closed.
  • resolution set to fixed.

(In [7806]) Fix unescaped test expectations. Closes #9821 [mikel]