[XPATCH] Add foreign_key as an type of column on migrations

If this were added at all it'd make sense for it to take a :polymorphic argument to also generate the _type column. This patch adds that functionality and some documentation.

Nice addition!

+1

it would be great if the :ref option from sexy_migrations was supported too. I'll try to implement it today and send the patch but I need to improve my ruby skills

Urubatan, I don't know if the ref option from sexy_migrations is supported on all database adapters.

Plus that sort of thing is culturally verboten for Rails anyway; we don't believe in foreign keys round these parts. Maybe the method should be called #belongs_to?

+1, minor: personally I would remove fkey alias

+1, sexier

+1 (on foreign_key_on_migrations_with_polymorphic_and_docs.patch). Lovely!

I'd also remove the fkey alias:

alias :fkey :foreign_key # Unnecessary

Actually, I'd keep the alias. Nice feature.

Nice one guys, I don't like the name 'foreign_key' as that's not what we're creating.

How about:

t.references :post

with an alias for

t.belongs_to :taggable, :polymorphic=>true

Finally, needs tests! :) Address those and we're good to go

Someone can point me to tests for the other column types, like t.string, t.integer, and so on?

I haven't added a test for this patch since I haven't found tests for those ones..

It would appear that we have no tests for that functionality.

MigrationTest contains some tests for t.column etc. So you could either expand on them, or perhaps whip up a simple mocha test?

  t.expects(:column).with(:customer_id, :integer)
  t.references :customer

I tried testing with mocha, using the following code, but get an failing test:

uses_mocha 'group_by_non_numeric_foreign_key_association' do
  def test_references_column_type_adds_id
    Person.connection.create_table :testings do |t|
      t.expects(:column).with(:customer_id, :integer)
      t.references :customer
    end
  end
end

I got this failure message:

 1) Failure:
test_references_column_type_adds_id(MigrationTest)
    [(eval):1:in `column'
     ./test/../lib/active_record/connection_adapters/abstract/schema_definitions.rb:445:in `references'
     ./test/../lib/active_record/connection_adapters/abstract/schema_definitions.rb:444:in `each'
     ./test/../lib/active_record/connection_adapters/abstract/schema_definitions.rb:444:in `references'
     ./test/migration_test.rb:876:in `test_references_column_type_adds_id'
     ./test/../lib/active_record/connection_adapters/abstract/schema_statements.rb:94:in `create_table'
     ./test/../lib/active_record/connection_adapters/mysql_adapter.rb:396:in `create_table'
     ./test/migration_test.rb:874:in `test_references_column_type_adds_id']:
#<Mock:0x36f29b4>.column('customer_id', :integer, {}) - expected calls: 0, actual calls: 1
Similar expectations:
column(:customer_id, :integer)

And I haven't found tests for the t.timestamps for example. I tried looking for this one and then modify mine, but...

-1 on fkey and foreign_key. +1 for suggestion to use references instead.

For more sexy migrations please also see #9881

Upload your patch so far and I'll take a look at the mocha failure if you like

Fine, here goes.

It would be a good idea to improve the coverage and test the t.timestamps as well.

+1 on last patch. A beauty!

Replying to arthurgeek:

Fine, here goes. It would be a good idea to improve the coverage and test the t.timestamps as well.

I don't see te mocha test there?

Sorry, my bad!

With tests

(In [7973]) Add t.belongs_to and t.references to sexy migrations [arthurgeek] Test harness for Sexy Migrations. [Koz] Closes #9775

Thanks for that, I've applied it now. The only difference was symbol vs strings and some empty hash args

I'm lazy today (and sleepy too).

There's a typo on my tests. Here goes another patch.

Sorry for that (again). :)