[PATCH] token_generator throttles inserts to 1/sec

I don't think this is necessary. #inspect already contains the memory address of the object. Even if each object has no attributes set, a new address is assigned for each and is visible in the return value of #inspect. So, in essence, appending rand isn't necessary.

In other words, when I use token_generator, I can create objects much faster than 1/sec because the address changes for each. Here's an example script/console session (the Question object includes TokenGenerator):

>> require 'benchmark'
=> []
>> puts Benchmark.measure { 600.times { Question.create } }
  1.590000   0.170000   1.760000 (  3.236665)
=> nil

That's obviously way faster at roughly 185/sec and would be even faster if it weren't actually touching the database.

Feel free to reopen if I misunderstood what you're trying to accomplish.

>> Track.new.inspect
=> "#<Track id: nil, token: nil, updated_at: nil, created_at: nil, json_cache: nil, merged_into_id: nil, takedown_id: nil, play_count: nil, activity_cache: nil>"

I don't get a memory address on my #inspect (but I have that funky new AR inspect format happening.) Maybe that's been changed (I'm running from Rails r7298), so things aren't an issue anymore.

I any case, with #rand in place, I get benchmarks like yours, without it, this is what I get:

>> require 'benchmark'
=> []
>> puts Benchmark.measure { 30.times { Track.create } }
 18.640000   1.600000  20.240000 ( 28.849825)

I'll try again on an up to date trunk over the weekend, and see if it's been fixed.

jchris, I see. I naively checked this against my only project that uses TokenGenerator (happened to be a Rails 1.2.3 instance). Your right. It looks like ActiveRecord::Base#inspect no longer has any memory addresses.

#{rand} added to md5 input in #generate_token

+1

It would be nice to be able to write a test for this kind of thing, but the plugin is without tests altogether, and I took the lazy route.

+1 It would be hilarious if the next 'Rails is slow' debater pointed out that Rails only lets you do some things once per second. Let's avoid that :-)

I learned a few things verifying this. Thanks :)

+1

(In [7965]) Increase randomness of TokenGenerator#generate_token by reusing CGI::Session.generate_unique_id. Closes #9622 [rmm5t, Jeremy Kemper]

Jeremy, I like the use of CGI::Session.generate_unique_id. Don't forget about the size of the token. Patch to fix regression forthcoming.

Fix for regression of the token size.

(In [7967]) Take first(size) chars for token. Closes #9622.