Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #9513 (closed task: fixed)

Opened 8 months ago

Last modified 8 months ago

Turn ActionController::Macros::InPlaceEditing into a plugin

Reported by: david Assigned to: core
Priority: normal Milestone:
Component: ActionPack Version: edge
Severity: normal Keywords: rails2
Cc:

Description

The ActionController::Macros::InPlaceEditing module should be turned into a plugin and removed from core. It's too high-level and often leaves people wanting more configuration options (components alert!).

Attachments

remove_in_place_editing.patch (10.8 kB) - added by lifofifo on 09/09/07 23:36:09.
Remove in place editing stuff from actionpack
in_place_editing.patch (10.7 kB) - added by lifofifo on 09/10/07 00:00:07.
Patch adding InPlaceEditing plugin to svn/plugin - Fixed typo in dir name

Change History

09/09/07 23:32:21 changed by david

  • component changed from ActiveRecord to ActionPack.

09/09/07 23:36:09 changed by lifofifo

  • attachment remove_in_place_editing.patch added.

Remove in place editing stuff from actionpack

09/10/07 00:00:07 changed by lifofifo

  • attachment in_place_editing.patch added.

Patch adding InPlaceEditing plugin to svn/plugin - Fixed typo in dir name

09/10/07 00:53:17 changed by david

  • status changed from new to closed.
  • resolution set to fixed.

(In [7442]) Moved ActionController::Macros::InPlaceEditing into the in_place_editor plugin on the official Rails svn (closes #9513) [lifofifo]

09/17/07 14:48:06 changed by akaspick

For anybody looking for some improvements to the in_place_editor, I've written a plugin that's available at http://agilewebdevelopment.com/plugins/improved_in_place_editor.

It currently doesn't work in edge as of this post since the http://agilewebdevelopment.com/plugins/improved_in_place_editor is now a plugin (this ticket), but I'll be working on adding some hooks to resolve the dependency between the plugins shortly.

09/17/07 14:49:39 changed by akaspick

That last comment didn't come out right. It should say...

It currently doesn't work in edge as of this post since the in_place_editor is now a plugin...

09/17/07 16:26:48 changed by akaspick

Maybe this isn't the right place for this, but how does one test and load a dependent plugin from another in edge?

Now that the inplace editor is a rails plugin, my plugin that I had written before will only work if this rails plugin is loaded first. Pre-edge I could have used the load_plugin method, but this method no longer exists in edge and from looking at the edge code for the initializer, I don't see an easy way for my plugin to check and fix this dependency now. Can anybody give me some clues on how I can fix this?

Forcing the user to use config.plugins in this case would not an ideal solution.

Thanks