Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #9454 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

[PATCH][DOCS] Small fixes in ActionController documentation

Reported by: sur Assigned to: core
Priority: normal Milestone: 1.x
Component: ActionPack Version: edge
Severity: normal Keywords: tiny docs
Cc:

Description

typos in action_controller docs in files assertions.rb, flash.rb, integration.rb and helpers.rb

Attachments

action_controller_docs_typos_fixed.diff (3.3 kB) - added by sur on 08/31/07 13:32:15.
patch fixing the typos and removing the deprecated docs in action_controller's docs
action_controller_docs_typos_fixed.2.diff (6.2 kB) - added by kampers on 08/31/07 16:35:44.
helpers_typo.diff (474 bytes) - added by Henrik N on 09/01/07 08:51:56.
One more typo: invokved -> invoked

Change History

08/31/07 12:38:44 changed by sur

  • summary changed from typos in action_controller documentations to [PATCH] [DOCS] typos in action_controller documentations.

08/31/07 13:14:08 changed by norbert

  • keywords changed from action_controller typos docs to tiny docs.
  • summary changed from [PATCH] [DOCS] typos in action_controller documentations to [PATCH][DOCS] Small fixes in ActionController documentation.

Obvious improvments. +1

08/31/07 13:16:08 changed by norbert

By the way, you might want to add "helper_attr method" instead of just "helper_attr".

08/31/07 13:26:42 changed by sur

norbert, I think "helper_attr" keeps the continuity of sentence with the "helper_method" as both are method names, so it is understood. Or otherwise we should use "method" with both of them. what say?

08/31/07 13:32:15 changed by sur

  • attachment action_controller_docs_typos_fixed.diff added.

patch fixing the typos and removing the deprecated docs in action_controller's docs

08/31/07 16:35:13 changed by kampers

Sur, I reviewed your patch and made some minor changes here and there.

  • I agree with Norbert about the "helper_attr method" thing, but I think an even better idea is to rewrite the doc to actually describe what it does. Check that out.
  • I added some monospacing and other whitespace fixes throughout.
  • I'm not a big fan of the practice of sticking a code block in the middle of a sentence, so I fixed two of those.

08/31/07 16:35:44 changed by kampers

  • attachment action_controller_docs_typos_fixed.2.diff added.

08/31/07 19:07:46 changed by bitsweat

  • status changed from new to closed.
  • resolution set to fixed.

(In [7383]) Documentation tweaks and fixes. Closes #9454 [sur, kampers]

09/01/07 08:51:56 changed by Henrik N

  • attachment helpers_typo.diff added.

One more typo: invokved -> invoked

09/01/07 08:52:48 changed by Henrik N

  • status changed from closed to reopened.
  • resolution deleted.

Saw this typo flash by in the changelog: attached patch fixed "invokved" -> "invoked".

Reopening this ticket rather than create a new one. Hope that makes sense.

09/01/07 12:50:18 changed by sur

  • status changed from reopened to closed.
  • resolution set to fixed.

As previous patches have already been committed, it will be good to merge this with any other related ticket. I am setting it to fixed now.