Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #9321 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[PATCH] Make Ajax.PeriodicalUpdater use new Ajax.Response wrapper to fix broken decaying

Reported by: kampers Assigned to: Tobie
Priority: normal Milestone: 1.x
Component: Prototype Version: edge
Severity: normal Keywords: prototype ajax periodicalUpdater
Cc:

Description

Ajax.PeriodicalUpdater wasn't updated to use the new Ajax.Response wrapper, so it no longer decays correctly. It's trying to compare two Ajax.Response objects directly instead of comparing their responseText, so it always thinks the response is different and never decays.

I think this slipped through because there are no tests for Ajax.PeriodicalUpdater. I'll try to whip some up in a bit, but here's a trivial patch to fix the bug in the meantime.

Attachments

periodicalupdater_decay_uses_response_wrapper.diff (0.7 kB) - added by kampers on 08/21/07 01:55:01.

Change History

08/21/07 01:55:01 changed by kampers

  • attachment periodicalupdater_decay_uses_response_wrapper.diff added.

08/21/07 07:30:04 changed by Tobie

  • owner changed from sam to Tobie.

Don't know how I've missed that... sorry!

08/21/07 16:18:11 changed by sam

  • status changed from new to closed.
  • resolution set to fixed.

(In [7353]) prototype: Fix Ajax.PeriodicalUpdater for compatibility with Ajax.Response. Closes #9321.