Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #9256 (closed defect: fixed)

Opened 11 months ago

Last modified 10 months ago

Uploading revision via copy zip (or tar.gz) file from Windows box to Unix type

Reported by: fukas78 Assigned to: Jamis Buck
Priority: normal Milestone:
Component: Capistrano Version: 1.2.3
Severity: major Keywords: windows upload deploy_via
Cc:

Description

Uploading revision via copy zip (or tar.gz) file from Windows to Unix box is broken. Reading files on Windows must be done in binary mode. Affected files are 'deploy.rb' and 'copy.rb'.

Every line with code like this: 

put File.read(filename), remote_filename

Should be rewritten like this: 

content = File.open(filename, "rb") { |f| f.read }
put content, remote_filename

Attachments

windows_binary_mode_bug.patch (1.3 kB) - added by fukas78 on 08/13/07 14:53:35.

Change History

08/13/07 14:53:35 changed by fukas78

  • attachment windows_binary_mode_bug.patch added.

08/30/07 14:22:04 changed by minam

  • status changed from new to closed.
  • resolution set to fixed.

(In [7376]) Use windows-safe binary reads for reading file contents (closes #9256)