[PATCH] Ajax.Request _complete flag not being reset

patch to move initialization of _complete in Ajax.Request to initialize

Can you retest with Prototype 1.6.0.2?

The problem still exists in 1.6.0.2. The fix is the same. Should I submit another patch over on GitHub?

Yes and please supply a failing test, because our unit tests are not picking up any errors.

Please submit a ticket in Lighthouse: http://www.prototypejs.org/contribute

I think it might be something else because this simple example shows:

var Base = Class.create({
  initialize: function(options) {
    this.options = options || {};
  }
});

var Something = Class.create(Base, {
  _complete: false,
  
  initialize: function($super, options){
    $super(options);
  },

  markComplete: function() {
    this._complete = true;
  }
});

var smth = new Something();
console.log(smth._complete); // false

smth.markComplete();
console.log(smth._complete); // true

var smth2 = new Something();
console.log(smth2._complete); // false

That _complete is false for every new instance.

Or even:

var a = new Ajax.Request();
a._complete = true;
var b = new Ajax.Request();
console.log(b._complete) //false

I'm not exactly sure how it is happening; like I said, I haven't been able to come up w/ a failing test case. I do know, though, that on our site, without my patch, JS code returned by Ajax.Request calls was not getting evaled after the first call--e.g. we have a session timeout pinger that makes a request every minute while a page is open, and only the first ping response will be evaled.