Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #9112 (new enhancement)

Opened 10 months ago

Last modified 6 months ago

[PATCH] remove paginate from scaffold.rb and list.erb, notice in README

Reported by: avocade Assigned to: core
Priority: normal Milestone: 2.x
Component: ActionPack Version: edge
Severity: normal Keywords: docs scaffold paginate
Cc:

Description

Since 'paginate' is going out of core the paginate code should be removed from scaffolding. I also added a "deprecated" notice in the README file.

'rake test' in actionpack/ checks out ok. This is my first patch to rails, so I there are sure to be errors somewhere.

Attachments

deprecated_notice_about_paginate_in_README_patch.diff (2.2 kB) - added by avocade on 07/26/07 18:49:26.
minor updates to README, scaffold.rb and index.erb in actionpack

Change History

07/26/07 18:49:26 changed by avocade

  • attachment deprecated_notice_about_paginate_in_README_patch.diff added.

minor updates to README, scaffold.rb and index.erb in actionpack

(follow-up: ↓ 2 ) 07/26/07 19:26:36 changed by kampers

This does the trick. My only thought is that the deprecation note in README only needs to appear on the 1.2-stable branch and not in trunk... but the committer can worry about that.

Congratulations on your first patch!

+1

(in reply to: ↑ 1 ) 07/26/07 20:06:45 changed by avocade

Thanks.

11/08/07 18:38:12 changed by jeremymcanally

What's the status of this patch? Is this information in Rails already and this needs to be closed? If not, this patch needs to be committed before 2.0 hits.