Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #9045 (closed defect: fixed)

Opened 1 year ago

Last modified 3 months ago

[PATCH] Replace command line with ActiveRecord for PostgreSQL create and drop of databases tasks

Reported by: ez Assigned to: core
Priority: normal Milestone: 2.x
Component: Railties Version: edge
Severity: normal Keywords: verified
Cc: tarmo, shingara, nicksieger

Description

A rake db:create and db:drop task in edge by Matt Aimonetti is using ActiveRecord for MySQL operations, but using command-line for PostgreSQL. This patch is using ActiveRecord for PostgreSQL create and drop of databases, support for it was included with a patch in ticket 9042.

This patch depends on ticket 9042.

Attachments

rails_postgresql_create_drop_db_tasks.patch (1.3 kB) - added by ez on 07/20/07 23:38:14.
Change db:create and db:drop tasks to use ActiveRecord instead of command line for PostgreSQL
rails_create_drop_db_postgres_9180.patch (1.7 kB) - added by nicksieger on 04/01/08 03:37:06.

Change History

07/20/07 23:38:14 changed by ez

  • attachment rails_postgresql_create_drop_db_tasks.patch added.

Change db:create and db:drop tasks to use ActiveRecord instead of command line for PostgreSQL

08/26/07 02:33:34 changed by tarmo

  • cc set to tarmo.
  • summary changed from Replace command line with ActiveRecord for PostgreSQL create and drop of databases tasks to [PATCH] Replace command line with ActiveRecord for PostgreSQL create and drop of databases tasks.

10/07/07 13:13:43 changed by shingara

  • cc changed from tarmo to tarmo, shingara.

02/05/08 13:40:03 changed by pedz

+1

02/22/08 18:03:51 changed by aeden

Unfortunately this patch does not apply cleanly to trunk. I do think it should be implemented though.

02/23/08 13:54:59 changed by pedz

I wouldn't mind redo'ing the patch so it would apply clean but it would drag out another year before it would get looked at again and by that point, the trunk will have moved on and not apply cleanly again.

This popular voting system I find disgusting. I've given up submitting patches at all. There are horrible bugs in Rails but since they are not glittery features being added, they never get voted on and they just sit there.

Instead, I have my pile of patches (like this one) to carry rails from the vaguely fun pile of code to something that actually functions Serious changes need to be address in how bugs are treated in my opinion.

Good luck with your toys.

04/01/08 03:37:06 changed by nicksieger

  • attachment rails_create_drop_db_postgres_9180.patch added.

04/01/08 03:37:44 changed by nicksieger

  • keywords set to verified.

+1. Updated patch. Please apply 9042 before this ticket.

04/01/08 03:38:41 changed by nicksieger

  • cc changed from tarmo, shingara to tarmo, shingara, nicksieger.

04/01/08 05:01:36 changed by bitsweat

  • status changed from new to closed.
  • resolution set to fixed.

(In [9183]) PostgreSQL: use create_ and drop_database for rake tasks. Closes #9045 [ez, nicksieger]