[PATCH] Add LibXML support to Active Resource

Please add tests and reopen the ticket.

No additional tests are needed, as it functions 100% the same as SimpleXML.

Thinking about this.. it might be necessary to copy the tests from Hash Conversion to the unit test for connection. Would that be a good idea?

-1

lifo:~/Rails/rails/activeresource pratik$ rake test   
(in /Users/pratik/Rails/rails/activeresource)
/opt/local/bin/ruby -w -Ilib:test "/opt/local/lib/ruby/gems/1.8/gems/rake-0.7.3/lib/rake/rake_test_loader.rb" "test/authorization_test.rb" "test/base/custom_methods_test.rb" "test/base/equality_test.rb" "test/base/load_test.rb" "test/base_errors_test.rb" "test/base_test.rb" "test/connection_test.rb" 
./test/../lib/../../activesupport/lib/active_support/dependencies.rb:495:in `require': no such file to load -- xml/libxml (MissingSourceFile)
        from ./test/../lib/../../activesupport/lib/active_support/dependencies.rb:495:in `require'
        from ./test/../lib/../../activesupport/lib/active_support/dependencies.rb:342:in `new_constants_in'
        from ./test/../lib/../../activesupport/lib/active_support/dependencies.rb:495:in `require'
        from ./test/../lib/active_resource/connection.rb:6
        from ./test/../lib/../../activesupport/lib/active_support/dependencies.rb:495:in `require'
        from ./test/../lib/../../activesupport/lib/active_support/dependencies.rb:495:in `require'
        from ./test/../lib/../../activesupport/lib/active_support/dependencies.rb:342:in `new_constants_in'
        from ./test/../lib/../../activesupport/lib/active_support/dependencies.rb:495:in `require'
         ... 10 levels...
        from /opt/local/lib/ruby/gems/1.8/gems/rake-0.7.3/lib/rake/rake_test_loader.rb:5:in `load'
        from /opt/local/lib/ruby/gems/1.8/gems/rake-0.7.3/lib/rake/rake_test_loader.rb:5
        from /opt/local/lib/ruby/gems/1.8/gems/rake-0.7.3/lib/rake/rake_test_loader.rb:5:in `each'
        from /opt/local/lib/ruby/gems/1.8/gems/rake-0.7.3/lib/rake/rake_test_loader.rb:5
rake aborted!
Command failed with status (1): [/opt/local/bin/ruby -w -Ilib:test "/opt/lo...]

(See full trace by running task with --trace)

You might want to read your error messages: no such file to load -- xml/libxml

Testing this without ruby-libxml seems a bit useless, doesn't it?

ActiveResource tests do not have dependancy on xml/libxml. All the tests pass when this patch is not applied.

Thanks.

Ah, I see. Hmm, there seems to be something strange going on in the trunk, when I fix the requirement in dependencies: /activesupport/lib/active_support/core_ext/time/calculations.rb:230:in `-': uninitialized constant ActiveSupport::Duration Will look into it.

I was thinking as activeresource as a plugin, but as it is going to be an integral part of rails, wouldn't it be more logical to just patch the hash.from_xml?

What happened to this? Seems like a pretty vital enhancement. With the REXML parser, ActiveResource is somewhat useless in anything other than the most lightweight/trivial cases. It's just way to slow to cope with real-world data.

I have been using it in production for over a year now. There are some more elegant patches out there that actually check if the hpricot/libxml/whatever gem is installed.

I had to strip all newline characters (\n) from the input XML, otherwise the patched code chokes.

... actually looks like this patch doesn't deal well with any XML indentation.

Looks like setting the following LibXml option fixes the indentation/whitespace problem, although I can't confirm that this will fully replicate REXML parsing behaviour (treatment of text nodes with whitespace might be different):

XML.default_keep_blanks = false

The patch also needs to be modified to convert dashes in node names to underscores.

I strip the newlines before feeding the data into LibXML. This actually seems faster. But this patch was intended for 2.0.1. Does it still work for 2.2?