Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #8680 (closed defect: duplicate)

Opened 1 year ago

Last modified 1 year ago

Prototype.js does not pass strict JS Lint testing

Reported by: dgrijalva Assigned to: sam
Priority: normal Milestone: 1.x
Component: Prototype Version: edge
Severity: normal Keywords:
Cc:

Description

As a base level library for many applications, it is important that prototype.js be as well formed as possible. Passing lint testing insures that the library will be as safe as possible for use with different javascript compressions libraries and improves general compliance with the javascript specification.

Attached is the diff file for bringing the trunk into compliance.

Attachments

lint_compliance.diff (13.8 kB) - added by dgrijalva on 06/18/07 21:56:55.
Diff file from revision 7058.

Change History

06/18/07 21:56:55 changed by dgrijalva

  • attachment lint_compliance.diff added.

Diff file from revision 7058.

06/18/07 22:10:06 changed by Tobie

  • status changed from new to closed.
  • resolution set to duplicate.

Please see #7311 and especially Andrew's comments at the bottom.

closing this as duplicate.

06/18/07 22:12:05 changed by Tobie

Sorry, meant Mislav's.

06/24/07 19:18:21 changed by dkubb

+1 for this patch.

I don't see the point in all the resistance behind having Prototype raise no warnings with lint tools. This seems to come up every month or so, and the amount of effort put into resisting what amounts to very minor cosmetic changes has got to be an unnecessary drain.

IMHO in some cases the lint tools are helpful, but because of the noise when using Prototype, real problems have gone unnoticed in my own code. I would prefer to have Prototype pass with no warnings.