Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #8650 (new defect)

Opened 1 year ago

Last modified 3 months ago

[PATCH] ActionView::Helpers::InstanceTag#tag has too few arguments

Reported by: jcoglan Assigned to: core
Priority: normal Milestone: 2.x
Component: ActionPack Version: edge
Severity: normal Keywords: unverified
Cc:

Description

Not sure if this is deliberate... I've written some code that wraps the tag method and including it in ActionView::Helpers::TagHelper works fine. Including it in ActionView::Helpers::InstanceTag breaks because it has a different number of arguments (it's missing the third argument, open). Should the methods be consistent?

Attachments

active_record_helper_tag_arguments.diff (0.9 kB) - added by jcoglan on 06/14/07 09:19:27.

Change History

06/14/07 09:19:27 changed by jcoglan

  • attachment active_record_helper_tag_arguments.diff added.

09/17/07 13:11:41 changed by jcoglan

  • keywords set to unverified.

12/14/07 00:43:10 changed by mdemare

+1

It doesn't solve anything at the moment, since you still can't request an input tag with an open-tag/close-tag syntax. But the issue is still relevant.

02/11/08 23:06:06 changed by ernesto.jimenez

It's missing two arguments now: opend and escape

def tag(name, options = nil, open = false, escape = true)

Patch should be updated