Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #8647 (closed enhancement: untested)

Opened 1 year ago

Last modified 1 year ago

[PATCH] correct setting of ActionController::Routing.controller_paths

Reported by: deepblue Assigned to: core
Priority: normal Milestone: 1.x
Component: Railties Version: edge
Severity: normal Keywords: initializer routes tiny
Cc:

Description

My plugin appends a path into ActionController::Routing.controller_paths, but this is not applied because the variable is reassigned in initialize_routing(after load_plugins).

So, I suggest the following change:

Before: 

ActionController::Routing.controller_paths = configuration.controller_paths

After: 

ActionController::Routing.controller_paths += configuration.controller_paths

Attachments

append_controller_paths_in_initialize_routing.diff (0.6 kB) - added by deepblue on 06/14/07 02:47:34.

Change History

06/14/07 02:47:34 changed by deepblue

  • attachment append_controller_paths_in_initialize_routing.diff added.

06/14/07 02:49:23 changed by deepblue

  • summary changed from [PATCH] to [PATCH] correct setting of ActionController::Routing.controller_paths.

07/31/07 10:37:01 changed by kampers

  • status changed from new to closed.
  • resolution set to untested.

Even though this would be, by definition, the smallest patch ever -- this strikes me as a potentially far-reaching change that could use a test. Can you work out a failing testcase? Please reopen this when that's good to go. Thanks.