Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #8493 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Changeset [6163] exposes fault with render_component setting ETag for the wrong response body

Reported by: jsierles Assigned to: core
Priority: normal Milestone: 1.2.4
Component: ActionPack Version: edge
Severity: normal Keywords:
Cc:

Description

render_component passes through the same response processing as any request, setting content-type, ETag, and so on. In Changeset [6163] a provision is made for allowing custom setting of the ETag header. Previously, direct requests overrode the render_component incorrect setting of the ETag against the component request content. A visible consequence of this is that modified view templates that have render_component calls will not update in the browser, causing much confusion.

A unit test and possible patch is attached. The patch simply bypasses response #prepare! for component requests.

Attachments

render_component_shouldnt_set_etag.diff (1.5 kB) - added by jsierles on 05/27/07 23:38:01.

Change History

05/27/07 23:38:01 changed by jsierles

  • attachment render_component_shouldnt_set_etag.diff added.

05/27/07 23:48:31 changed by bitsweat

  • status changed from new to closed.
  • resolution set to fixed.

(In [6875]) Don't prepare response when rendering a component. Closes #8493.