Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #8396 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

[PATCH] Regression in Logger breaks Edge on Ruby 1.8.2

Reported by: mislav Assigned to: nzkoz
Priority: high Milestone: 1.x
Component: ActiveSupport Version: edge
Severity: normal Keywords: 1.8.2 regression logger
Cc:

Description

I've noticed this on my Debian deploy box. [2369] fixed Logger for 1.8.2 and 1.8.3, but the most recent changeset to clean_logger.rb, [6225], breaks it again by expecting Logger#formatter and Logger::Formatter, none of which exists in Ruby 1.8.2.

Attachments

clean_logger.diff (3.5 kB) - added by mislav on 06/22/07 22:22:36.

Change History

06/15/07 22:25:54 changed by josh

  • priority changed from high to normal.

Can you please attach some test cases or some code snippet that will prove the existence of the bug?

06/15/07 22:32:40 changed by mislav

There is nothing to prove. [6225] change the code to expect methods and classes that are not there. I don't need a failing test case also, because the whole framework fails to load on Ruby 1.8.2 because of this.

Are you saying it works for you on 1.8.2?

06/15/07 23:39:12 changed by josh

According to the site, we are supposed to be supporting 1.8.2. I just want to double check the policy on the mailing list.

06/16/07 03:30:25 changed by josh

Cool, it looks like we should be supporting it. Any ideas on actually fixing it?

06/22/07 22:22:36 changed by mislav

  • attachment clean_logger.diff added.

06/22/07 22:28:33 changed by mislav

  • priority changed from normal to high.
  • severity changed from minor to normal.
  • summary changed from Regression in Logger breaks Edge on Ruby 1.8.2 to [PATCH] Regression in Logger breaks Edge on Ruby 1.8.2.

I've attached the patch. Please, this is biting on every rails:freeze:edge I do without patching it immediately after.

Tested on 1.8.2 and 1.8.5.

It wasn't so hard to fix after I understood what happened in Ruby 1.8.2-1.8.3 to 1.8.4. I also removed a redundant test case where there was some hacks to check if a hack is working. I understood what it does but it was entirely unnecessary since the main unit tests provide enough coverage for this.

06/22/07 23:09:14 changed by nzkoz

  • status changed from new to closed.
  • resolution set to fixed.

(In [7083]) Ensure clean_logger fixes are 1.8.2 compatible [mislav] Closes #8396