drop_receiving_element doesn't quote confirm option

Replying to xtoddx:

When making a drop_receiving_element with a :confirm=>'really do it?', the confirm works well for the Ajax.Updater, but the confirm is also in the Droppables.add() options, and it is unquoted, which leads to a javascript error. Rails 1.2.3 Sample: {{{ <%= drop_receiving_element('photo_trash', :hoverclass=>'dropready', :url=>{:action=>'aj_image_delete'}, :confirm=>"Really delete image?") %> }}} Yields: {{{ Droppables.add("photo_trash", {confirm:Really delete image?, hoverclass:'dropready', onDrop:function(element){if (confirm('Really delete image?')) { new Ajax.Request('/office/aj_image_delete', {asynchronous:true, evalScripts:true, parameters:'id=' + encodeURIComponent(element.id)}); }}}) }}}

Same problem for :submit. Adds "parameters:Form.serialize('form_id')" correctly but even a "submit:form_id" which leads to the mentioned javascript error.

This patch file ensures that the :confirm option works without having to supply extra quotes on the drop_receiving_element helper

[PATCH] This is caused by the :confirm option being passed through to the Droppables.add javascript method - where it doesn't get used and basically throws up.

Attached is a tiny little patch that ensures that the :confirm option is thrown away once it serves its purpose, and doesn't despoil the Droppable.add method.

SO this:

drop_receiving_element('photo_trash', :hoverclass=>'dropready', :url=>{:action=>'aj_image_delete'}, :confirm=>"Really delete image?") %>

generates this:

Droppables.add("photo_trash", {hoverclass:'dropready', onDrop:function(element){if (confirm('Really delete image?')) { new Ajax.Request('/office/aj_image_delete', {asynchronous:true, evalScripts:true, parameters:'id=' + encodeURIComponent(element.id)}); }}})

instead of this:

Droppables.add("photo_trash", {confirm:Really delete image?, hoverclass:'dropready', onDrop:function(element){if (confirm('Really delete image?')) { new Ajax.Request('/office/aj_image_delete', {asynchronous:true, evalScripts:true, parameters:'id=' + encodeURIComponent(element.id)}); }}})

(This patch includes a little test to verify it works)

+1, seems to work

+1

+1

(In [8879]) Ensure that :confirm doesn't need extra quotes when using drop_receiving_element. Closes #8299 [thechrisoshow]