Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #8234 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[PATCH] fix broken compile templates test on windows

Reported by: skaes Assigned to: nzkoz
Priority: normal Milestone: 1.x
Component: ActionPack Version: edge
Severity: normal Keywords:
Cc:

Description

windows does not support symlinks. test should not test sysmlink behaviour in this case-

Attachments

fix_broken_compiled_template_test.patch (3.2 kB) - added by skaes on 05/01/07 07:54:54.
fix_broken_compiled_template_test.trunk.patch (5.9 kB) - added by skaes on 05/27/07 04:05:17.
trunk version of the patch
fix_broken_compiled_template_test.2.patch (3.2 kB) - added by skaes on 05/27/07 09:09:48.

Change History

05/01/07 07:54:54 changed by skaes

  • attachment fix_broken_compiled_template_test.patch added.

05/07/07 16:30:48 changed by skaes

This is meant for 1-2-stable. I'll add a trunk version later.

05/27/07 04:05:17 changed by skaes

  • attachment fix_broken_compiled_template_test.trunk.patch added.

trunk version of the patch

05/27/07 04:09:11 changed by nzkoz

  • owner changed from rick to nzkoz.
  • status changed from new to assigned.

05/27/07 07:33:52 changed by nzkoz

  • owner changed from nzkoz to skaes.
  • status changed from assigned to new.

I've applied the trunk changes, however the stable changes introduce a failure: 

  1) Failure:
test_compile_time(CompiledTemplateTests)
    [./test/template/compiled_templates_test.rb:133:in `test_compile_time'
     /opt/local/lib/ruby/gems/1.8/gems/mocha-0.4.0/lib/mocha/test_case_adapter.rb:19:in `run']:
<false> is not true.

1201 tests, 5987 assertions, 1 failures, 0 errors

05/27/07 07:52:27 changed by skaes

  • status changed from new to assigned.

I get the same error on windows without the patch. I'll investigate.

05/27/07 08:59:10 changed by skaes

  • component changed from ActiveRecord to ActionPack.

05/27/07 09:09:48 changed by skaes

  • attachment fix_broken_compiled_template_test.2.patch added.

05/27/07 09:10:45 changed by skaes

  • owner changed from skaes to nzkoz.
  • status changed from assigned to new.

the patch was missing a sleep

05/29/07 09:58:33 changed by nzkoz

  • status changed from new to closed.
  • resolution set to fixed.

(In [6895]) Fix template compile tests on windows [skaes] closes #8234