Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #823 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[PATCH] SQLite3 exceptions are not being wrapped in ActiveRecord::StatementInvalid when logging

Reported by: yerejm Assigned to: David
Priority: normal Milestone:
Component: ActiveRecord Version: 0.10.0
Severity: normal Keywords:
Cc:

Description

Current exception handling for log_info rescues StandardError Exception derivatives. SQLite3 is derived from Exception and so any SQLite3Exception raised escapes AR and the failing SQL is not logged.

Attachments

sql_exception_patch.diff (2.6 kB) - added by yerejm on 03/12/05 08:58:38.
Patch to handle SQLite3 Exceptions

Change History

03/12/05 08:58:38 changed by yerejm

  • attachment sql_exception_patch.diff added.

Patch to handle SQLite3 Exceptions

03/12/05 08:59:48 changed by anonymous

  • summary changed from SQLite3 exceptions are not being wrapped in ActiveRecord::StatementInvalid when logging to [PATCH] SQLite3 exceptions are not being wrapped in ActiveRecord::StatementInvalid when logging.

03/12/05 09:01:29 changed by yerejm

Also piggyback patch to make sqlite tests run on Windows. Current method using single quotes is not liked by sqlite's windows executable, so this has been changed to double quotes.

03/14/05 23:48:44 changed by david

  • status changed from new to closed.
  • resolution set to fixed.