[PPATCH] big filter speedup

deleted a superflous assignment

trunk version of the patch

(In [6650]) apply [6649] to stable, closes #8226 [Stefan Kaes]

This patch breaks EzCrypto and ActiveCrypto - not a suitable "enhancement" for stable?

ActiveCrypto uses the following:

module ActionController
  def self.append_features(base)
    super
    base.send :prepend_after_filter, :save_session_keys
    base.send :prepend_before_filter, :load_session_keys
  end
...

In my application, which also uses a "set_locale" filter, the filter chain sent to call_filters(chain, index, nesting) looks like this:

(output of "puts chain.to_yaml")

- !ruby/object:ActionController::Filters::ClassMethods::BeforeFilterProxy 
  filter: !ruby/object:ActionController::Filters::ClassMethods::SymbolFilter 
    filter: :set_locale
- !ruby/object:ActionController::Filters::ClassMethods::AfterFilterProxy 
  filter: !ruby/object:ActionController::Filters::ClassMethods::SymbolFilter 
    filter: :save_session_keys
- !ruby/object:ActionController::Filters::ClassMethods::BeforeFilterProxy 
  filter: !ruby/object:ActionController::Filters::ClassMethods::SymbolFilter 
    filter: :load_session_keys

The error I get is:

filter #<ActionController::Filters::ClassMethods::BeforeFilterProxy:0x276f290 @filter=#<ActionController::Filters::ClassMethods::SymbolFilter:0x276f2f4 @filter=:load_session_keys>> was in the wrong place!

It appears that call_filters stops processing before_filters when it encounters the after_filter, then throws the error when it encounters the unprocessed before_filter.

A very cludgy and bad fix for this in the ActiveCrypto context is to change the order in which "prepend_before_filter" and "prepend_after_filter" are called, so that "prepend_after_filter" is called _first_, and "prepend_before_filter" thus prepends the before filter before the after filter (gah).

Can you provide a failing test case for the rails filter tests?

Here ya go:

  class PrependingBeforeAndAfterController < ActionController::Base
    prepend_before_filter :before_all
    prepend_after_filter :after_all
    before_filter :sorta_before

    def before_all
        @ran_filter ||= []
        @ran_filter << 'before_all'
    end

    def after_all
        @ran_filter ||= []
        @ran_filter << 'after_all'
    end

    def sorta_before
        @ran_filter ||= []
        @ran_filter << 'sorta_before'
    end
    def show
    end
  end

  def test_running_prepended_before_and_after_filter
      #assert_equal 1, PrependingBeforeAndAfterController.filter_chain
      response = test_process(PrependingBeforeAndAfterController)
      assert_equal %w( before_all sorta_before after_all ), response.template.assigns["ran_filter"]
  end

Note that the response code to this test is '500'. I couldn't figure out how to get the trace and error message that shows up in the development environment to display in the test environment, but is this enough to show the problem?

rick, can you add the test to trunk. I'll fix the problem tomorrow.

bug fix for filter chain ordering

added 2 new test cases:

• test_empty_filter_chain
• test_running_prepended_before_and_after_filter

chain ordering patch for 1-2-stable

fixed in [6671]