Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #8174 (closed enhancement: fixed)

Opened 2 years ago

Last modified 1 year ago

[PATCH] Render template for custom mime handler without blocks

Reported by: josh Assigned to: josh
Priority: normal Milestone: 1.2.4
Component: ActionPack Version: edge
Severity: minor Keywords: respond_to
Cc:

Description

Respond_to should try to render template for custom mime handler without blocks instead of craping out with an exception.

Attachments

custom_constant_handling_without_block.diff (1.9 kB) - added by josh on 04/25/07 02:48:35.
refactor_mime_responds.diff (10.1 kB) - added by josh on 05/26/07 03:01:45.

Change History

04/25/07 02:48:35 changed by josh

  • attachment custom_constant_handling_without_block.diff added.

05/26/07 01:33:10 changed by josh

  • keywords changed from respond_to tiny to respond_to.

(Don't set tiny on your own patches)

05/26/07 03:01:45 changed by josh

  • attachment refactor_mime_responds.diff added.

05/26/07 03:11:38 changed by bitsweat

  • status changed from new to closed.
  • resolution set to fixed.

(In [6856]) Introduce a default respond_to block for custom types. Closes #8174.

05/26/07 03:19:01 changed by bitsweat

(In [6857]) Missed svn add from [6856]. References #8174.

07/05/07 11:27:49 changed by brandon

One of the unintended consequences of this change is that you can no longer render HTML in response to Ajax calls, for example when calling link_to_remote with :update. See http://pastie.caboo.se/76204 for more explanation.

07/06/07 23:30:21 changed by nzkoz

  • status changed from closed to reopened.
  • resolution deleted.

Could we get a response to brandon's issue?

07/06/07 23:30:32 changed by nzkoz

  • owner changed from core to josh.
  • status changed from reopened to new.

09/10/07 13:51:07 changed by josh

  • status changed from new to closed.
  • resolution set to fixed.

I kind of think thats the expected behavior. A JS format should be trying to render a JS template by default, not an html one. I'm actually not sure how it was working before. Looking at the old code it looks like it was intended to have the same behavior as well.

If you disagree, could you open another ticket reporting the problem.