Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #8157 (closed task: fixed)

Opened 2 years ago

Last modified 1 year ago

[PATCH] Remove Pagination from Rails

Reported by: josh Assigned to: nzkoz
Priority: high Milestone: 1.x
Component: ActionPack Version: edge
Severity: normal Keywords: pagination deprecation
Cc: aeden, mislav

Description

Pagination is in same boat as dynamic scaffolding, both will be extracted into plugins by Rails 2.0. Just to show my continuing love of the Core team crushing the promising dreams of much loved features, I decided to do the work for you.

In #7700, dynamic scaffolding was moved into a separate plugin and deprecated in core. Same thing here. Move pagination to its own plugin, users see the deprecation notice, install the plugin, and it goes away.

This plugin also includes some simple updates from the following tickets. * http://dev.rubyonrails.org/ticket/4113 * http://dev.rubyonrails.org/ticket/4116 * http://dev.rubyonrails.org/ticket/7133

Attachments

deprecate_pagination.diff (6.0 kB) - added by josh on 04/24/07 00:50:03.
pagination_plugin.diff (37.7 kB) - added by josh on 04/24/07 00:50:17.
remove-pagination.diff (25.7 kB) - added by mislav on 05/20/07 23:31:08.
patch to completely remove Pagination from Rails
deprecation-for-stable.diff (4.0 kB) - added by mislav on 05/27/07 01:11:57.

Change History

04/24/07 00:50:03 changed by josh

  • attachment deprecate_pagination.diff added.

04/24/07 00:50:17 changed by josh

  • attachment pagination_plugin.diff added.

04/24/07 02:54:50 changed by aeden

  • cc set to aeden.

05/20/07 23:30:14 changed by mislav

  • cc changed from aeden to aeden, mislav.
  • priority changed from normal to high.
  • component changed from Plugins to ActionPack.
  • severity changed from minor to normal.
  • summary changed from [PATCH] Move Pagination into its own plugin to [PATCH] Remove Pagination from Rails.

Pagination has just been extracted and hosted side by side with will_paginate. Changeset 229 in that repository also fixes #8176, #7325, #7028, #4113. I marked a bunch of other patches wontfix because we're removing Pagination anyway.

05/20/07 23:31:08 changed by mislav

  • attachment remove-pagination.diff added.

patch to completely remove Pagination from Rails

05/26/07 02:48:17 changed by nzkoz

  • owner changed from bitsweat to nzkoz.
  • status changed from new to assigned.

05/27/07 01:11:57 changed by mislav

  • attachment deprecation-for-stable.diff added.

05/27/07 01:23:50 changed by mislav

Koz: Patch for stable branch added.

06/11/07 00:51:14 changed by bitsweat

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6992]) Deprecation: remove pagination. Install the classic_pagination plugin for forward compatibility, or move to the superior will_paginate plugin. Closes #8157.

06/11/07 01:01:35 changed by bitsweat

(In [6993]) Deprecate pagination for Rails 1.2.4. Install the classic_pagination plugin for forward compatibility, or move to the superior will_paginate plugin. References #8157.