Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #7583 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[PATCH] eliminate another dynamic require (pstore)

Reported by: skaes Assigned to: core
Priority: high Milestone: 1.2.4
Component: ActionPack Version: edge
Severity: major Keywords: dynamic require
Cc:

Description

The default implementation of CG::Session::Pstore executes a require in it's initialize method. Which is really expensive for Rails. Attached path fices this problem.

Attachments

pstore_performance_fix.patch (1.3 kB) - added by skaes on 02/18/07 19:14:23.
pstore_performance_fix2.patch (1.7 kB) - added by skaes on 02/19/07 19:49:14.
now complete

Change History

02/18/07 19:14:23 changed by skaes

  • attachment pstore_performance_fix.patch added.

02/19/07 01:11:03 changed by dcmanges

  • summary changed from [PPATCH] eliminate another dynamic require (pstore) to [PATCH] eliminate another dynamic require (pstore).

Fixing summary.

skaes - could you check the patch file - it looks like it's diff'd against revision 0?

02/19/07 04:20:49 changed by skaes

Nothing wrong with the patch. This is a new file.

02/19/07 15:03:48 changed by dcmanges

Ah, I see why I was confused - the patch needs to require the file in actionpack/lib/action_controller/cgi_process.rb

02/19/07 19:49:14 changed by skaes

  • attachment pstore_performance_fix2.patch added.

now complete

03/16/07 05:55:53 changed by bitsweat

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from 1.x to 1.2.4.

[6431] trunk, [6432] 1-2-stable