[PATCH] Incorrect isLeftClick code, plus isRightClick and isMiddleClick

this patch throws _isSpecificButton is not defined (Line 2212)

to solve this change _isSpecificButton to Event._isSpecificButton in isLeftClick, isMiddleClick & isRightClick

Fixed the "undefined" error.

Now fixed!

TDD, can you please check if those changes are covered in the events branch ?

Tobie: they're not AFAICS. It still uses the legacy, incorrect test, and it has no is(Right|Middle)Click methods.

You have commit rights to that branch... don't you ? ;-)

Fixed in [6537].

Still, to be merged in trunk.

Reopened because, er, it's not merged in trunk after all. It's in the events branch, though.

Example to show different values for Event.button and Event.which in IE and FF

I see that the values of Event.button and Event.which are different from IE7 and FF2.

I've attached a fairly complete html script (uses prototype.js only).

But I hope you can see what I'm trying to prove. The extension to the Event object would need to be merged into event.js.

Just to recap.

On IE7

Left button clicked - Event.which = 1 and Event.button = 1 Right button clicked - Event.which = 1 and Event.button = 2 Middle button clicked - Event.which = 1 and Event.button = 4

The buttons can be OR'd to be used as a bitmask for multiple/simultaneous button pressing, but it seems that in my testing each button always produced its own mousedown event - the click event didn't populate Event.which or Event.button with different information for different buttons.

On FF2

Left button clicked - Event.which = 0 and Event.button = 1 Right button clicked - Event.which = 2 and Event.button = 3 Middle button clicked - Event.which = 1 and Event.button = 2

If using the click event rather than the mousedown event, only the primary button is captured but in this instance the values for Event.which and Event.button where consistent with the mousedown event values.

And for the first time, I used Opera9 and the results were interesting. I had to enable the "Allow Right Click" option first. Thereafter, the left and right buttons matched FF2. The middle button didn't respond at all. This is with the mousedown event. The click event only worked on the primary button but at least the value matched that of the mousedown event.

Phew. Quite a lot of work there. I hope this is useful.

Regards,

Richard Quadling.

Event.which and Event.button are both different in IE and FF.

Updated patch with full functional test against current trunk, extracted from the fx test in the events branch.

Added the trunk-relevant parts of the events branch's functional tests. Works alright with both functional and unit tests.

Being new here, do I need to to anything?

(In [7926]) prototype: Cross-browser Event#isLeftClick with the addition of is(Middle|Right)Click. Closes #7520.

Using a slightly amended clicker.html and using the new rc1, I'm still having a problem. Left clicking in IE7 responds as if middle click has been made. Middle clicking isn't recognised correctly at all.

See code at http://pastie.caboo.se/108034 and the newly attached clicker_V1.6.0rc1.html

I seem to have fixed this by making the isButton function a member function to the Event class.

I've also attached a patch for that based upon 1.6.0rc1.

Show the event info when mouse clicking.

Patch to fix left/right/middle clicks. Tested on IE7/FF2 WinXPSP2

Richard, thanks for reporting. The solution in fact is much simpler and doesn't require merging browser-specific code to one function. I've attached a patch.

tested in IE7, Opera and FF (Windows)

Testing that at my end ...

And yippee!

Thanks.

I see that my attempt at fixing this was OK (i.e. turn isButton into a method). I merged the browser code at the same time as 'cause I didn't think ...

One final question..

return isButton(event, ..);

vs

return Event.pointer(event)..

Shouldn't it be ...

return Event.isButton(event, ...);

?

(In [7954]) prototype: Fix Event#is(Left|Middle|Right)Click in IE. Closes #7520.

Replying to RQuadling:

Shouldn't it be return Event.isButton(event, ...)

isButton here is a private method accessed through a closure - there isn't a need for making it public

Replying to mislav:

Replying to RQuadling:

Shouldn't it be return Event.isButton(event, ...)

isButton here is a private method accessed through a closure - there isn't a need for making it public

Aha. I see. Thank you.