Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #7477 (closed defect: incomplete)

Opened 1 year ago

Last modified 1 year ago

[PATCH] Fixed broken tests in active support to_query

Reported by: chadfowler Assigned to: core
Priority: normal Milestone: 1.x
Component: ActiveSupport Version: edge
Severity: normal Keywords: needy
Cc:

Description

The tests for to_query were relying on hashes being in the right order.

Attachments

fix_broken_active_support_to_query_tests.diff (1.5 kB) - added by chadfowler on 02/04/07 13:50:02.
Patch for active support hash tests

Change History

02/04/07 13:50:02 changed by chadfowler

  • attachment fix_broken_active_support_to_query_tests.diff added.

Patch for active support hash tests

02/24/07 18:44:13 changed by josh

  • keywords set to needy.
  • milestone changed from 1.2 to 1.x.

Tests are failing for me. 

  1) Failure:
test_multiple_nested(QueryTest)
    [./test/core_ext/hash_ext_test.rb:567:in `assert_equal_one_of'
     ./test/core_ext/hash_ext_test.rb:556:in `test_multiple_nested']:
Expected one of:
account[person][id]=20&person[id]=10, OR person[id]=10&account[person][id]=20 but got:
person%5Bid%5D=10&account%5Bperson%5D%5Bid%5D=20.
<false> is not true.

  2) Failure:
test_nested_conversion(QueryTest)
    [./test/core_ext/hash_ext_test.rb:567:in `assert_equal_one_of'
     ./test/core_ext/hash_ext_test.rb:550:in `test_nested_conversion']:
Expected one of:
person[name]=Nicholas&person[login]=seckar, OR person[login]=seckar&person[name]=Nicholas but got:
person%5Blogin%5D=seckar&person%5Bname%5D=Nicholas.
<false> is not true.

07/19/07 12:47:31 changed by mpalmer

  • status changed from new to closed.
  • resolution set to incomplete.

The patch, as given, fails to apply on r7195. Please update the patch and reopen this ticket.