Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #7139 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

[PATCH] Create a label_tag helper

Reported by: jarkko Assigned to: nzkoz
Priority: normal Milestone: 2.x
Component: ActionPack Version: edge
Severity: normal Keywords: label helper
Cc: ian@ianduggan.net, pauljbarry3

Description

A placeholder for a patch that creates a label_for helper for easy creation of label tags for form helpers. See #362 for more information. I will post a patch when I wake up tomorrow.

Attachments

patch-for-7139.diff (4.1 kB) - added by jarkko on 01/18/07 07:55:05.
Patch with tests and docs
patch-for-7139.2.diff (10.5 kB) - added by jarkko on 01/18/07 13:46:32.
Updated patch with support for form_for and form builders

Change History

01/17/07 22:48:50 changed by eventualbuddha

  • keywords set to label helper.
  • type changed from defect to enhancement.

01/18/07 07:55:05 changed by jarkko

  • attachment patch-for-7139.diff added.

Patch with tests and docs

01/18/07 08:00:48 changed by jarkko

  • cc set to nzkoz.

Ok, I added an enhanced patch with support for indexed fields ("post_123_title"), tests and docs. What do you guys think?

01/18/07 08:06:17 changed by manfred

Very nice +1.

01/18/07 13:46:32 changed by jarkko

  • attachment patch-for-7139.2.diff added.

Updated patch with support for form_for and form builders

01/18/07 13:47:34 changed by jarkko

  • summary changed from Create a label_tag helper to [PATCH] Create a label_tag helper.

Updated the patch with support for using it inside form_for and form builders.

01/20/07 14:14:22 changed by dkubb

+1

I'd really like to see this be accepted so that all the generator templates (like scaffolding's) can be updated to use label tags instead of unsemantic "p/b" tag combos.

01/20/07 15:03:25 changed by jarkko

  • cc deleted.
  • owner changed from jarkko to nzkoz.

06/02/07 21:24:29 changed by ijcd

  • cc set to ian@ianduggan.net.

07/03/07 01:07:19 changed by pauljbarry3

  • cc changed from ian@ianduggan.net to ian@ianduggan.net, pauljbarry3.

I would also like to see this accepted, and the scaffold to use label rather than b

10/12/07 08:46:05 changed by jarkko

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in r7541.