Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #7042 (new defect)

Opened 3 years ago

Last modified 3 years ago

[PATCH][DOCS] - add note for assert_select docs warning that it may fail on XML

Reported by: rsanheim Assigned to: core
Priority: normal Milestone: 1.2.7
Component: ActionPack Version: edge
Severity: normal Keywords: docs
Cc:

Description

Adding a note to the assert_select docs explaining that it often won't work for XML documents, and providing a reference to Jamis' blog entry (http://weblog.jamisbuck.org/2007/1/4/assert_xml_select) which has more details on the issue.

In the long term it might be better to add real xml support at some point, but for now the docs should at least warn users that assert_select will fail with many xml documents. The behavior can be surprising as assert_select will work fine with some xml, but then fail when you try to use a tag thats self-closing in HTML (ie link or meta).

Attachments

assert_select_doc_fix.diff (0.7 kB) - added by rsanheim on 01/15/07 04:03:01.

Change History

01/15/07 03:57:50 changed by rsanheim

  • summary changed from [PATCH][DOC] to [PATCH][DOCS] - add note for assert_select docs warning that it may fail on XML.

01/15/07 04:03:01 changed by rsanheim

  • attachment assert_select_doc_fix.diff added.

03/29/07 19:32:34 changed by richie

I would personally vote against this in favor of incorporating some fix (even jamis's) into the code base.

Also, some documentation should be provided of examples/contexts where assert_select will fail on an xml document.