Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #704 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[PATCH] TimeZone issues in action-pack and active-support

Reported by: jamis_buck@byu.edu Assigned to: David
Priority: normal Milestone:
Component: ActiveRecord Version: 0.9.5
Severity: normal Keywords:
Cc:

Description

In trying to backport the new TimeZone support into Basecamp, I ran into some issues. First of all, the time_zone_select was misengineered; the moron thought he could code it up without actually testing it in the wild first. (ahem) Also, the value object itself needed a little more love (it was missing a few pieces that were in the original BC version, but didn't get transfered). This patch is sufficient to make time_zone_select work in BC.

Attachments

action_pack_tz.patch (1.7 kB) - added by minam on 02/23/05 21:36:50.
Modifications to the form_options_helper
active_support_tz.patch (0.6 kB) - added by minam on 02/23/05 21:37:31.
Minor modifications to the TimeZone value object.
fixed-form-options-helper-tests.patch (9.1 kB) - added by minam on 02/24/05 05:28:59.
fixed unit tests for the form_options_helper unit tests

Change History

02/23/05 21:36:50 changed by minam

  • attachment action_pack_tz.patch added.

Modifications to the form_options_helper

02/23/05 21:37:31 changed by minam

  • attachment active_support_tz.patch added.

Minor modifications to the TimeZone value object.

02/23/05 21:38:11 changed by jamis_buck@byu.edu

  • summary changed from TimeZone issues in action-pack and active-support to [PATCH] TimeZone issues in action-pack and active-support.

02/23/05 23:56:03 changed by david

  • status changed from new to closed.
  • resolution set to fixed.

02/24/05 01:50:04 changed by caleb@aei-tech.com

  • status changed from closed to reopened.
  • resolution deleted.

This patch causes the unit tests for this module to fail.

Sample:

1) Failure:

test_time_zone_options_no_parms(FormOptionsHelperTest) ./test/template/form_options_helper_test.rb:136: <"<option>A</option>\n<option>B</option>\n<option>C</option>\n<option>D</option>\n<option>E</option>"> expected but was <"<option value=\"A\">A</option>\n<option value=\"B\">B</option>\n<option value=\"C\">C</option>\n<option value=\"D\">D</option>\n<option value=\"E\">E</option>">.

02/24/05 05:28:59 changed by minam

  • attachment fixed-form-options-helper-tests.patch added.

fixed unit tests for the form_options_helper unit tests

02/24/05 11:51:06 changed by david

  • status changed from reopened to closed.
  • resolution set to fixed.