Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #6887 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

[PATCH] Form.disable on non-form elements

Reported by: csturm Assigned to: sam
Priority: normal Milestone: 1.x
Component: Prototype Version: edge
Severity: minor Keywords: ready
Cc:

Description

after upgrading to the latest prototype that came with rails 1.2rc1, Form.disable no longer works if

1. the parameter is the name of a fieldset

2. the browser is firefox (tested with 2.0.1)

I dont know if disabling fieldsets was ever documented, but it worked with prototype 1.4, and now it doenst work. (And its a really cool feature)

Attachments

non-form-disable.diff (1.8 kB) - added by mislav on 02/07/07 01:34:41.
here you go + unit tests with fieldset ;)

Change History

12/26/06 01:51:25 changed by jonathan_viney

The Form.* methods only work on <form> elements now, this affected me as well, see the discussion here:

http://groups.google.com/group/rubyonrails-spinoffs/browse_thread/thread/483f1eeb2350a8d7/5c2ed13ad1e63a4c?lnk=gst&q=viney&rnum=1

I also provided a workaround in that thread.

12/31/06 18:43:21 changed by david

#6898 depends on a fix to this too.

01/05/07 00:12:12 changed by sam

  • keywords deleted.

We'll introduce an API for working with collections of arbitrary form elements in Prototype 1.5.1.

01/05/07 00:18:02 changed by sam

(In [5841]) prototype: Form.serialize once again works with non-form elements. This is a temporary change to prevent the Rails link_to_remote regression described in #6898. Prototype 1.5.1 will introduce an API for working with collections of arbitrary form elements. References #6887. Closes #6898.

02/07/07 01:28:04 changed by mislav

  • version changed from 1.2.0rc1 to edge.
  • summary changed from Form.disable no longer works with a fieldset in firefox to [PATCH] Form.disable on non-form elements.

02/07/07 01:34:41 changed by mislav

  • attachment non-form-disable.diff added.

here you go + unit tests with fieldset ;)

03/27/07 17:03:11 changed by mislav

  • keywords set to ready.
  • severity changed from normal to minor.

03/27/07 17:54:07 changed by madrobby

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in [6474].