[PATCH] generated URL helpers ignore request's parameters

suggested patch

Can you please provide a failing test case? As a counter, here is a test case that looks like it should fail, but it doesn't:

  def test_named_route_should_not_choose_other_routes
    rs.draw do |map|
      map.connect '/wrong/:login', :controller => 'admin/user', :action => 'show'
      map.user '/admin/user/:login', :controller => 'admin/user', :action => 'show'
    end
    x = setup_for_named_route.new
    h = x.send(:user_path, :login => 'dhh')
    h.delete :only_path
    assert_equal '/admin/user/dhh', rs.generate(h)
  end

By the way, you might want to check and ensure that you do not have to named routes with the same name -- if you do, then the latter one will take precedence and lead to behavior such as this.

Related thread: http://groups.google.com/group/rubyonrails-core/browse_thread/thread/82df77fc4a8e5f22/f6d663bafd0be0e4?hl=en#f6d663bafd0be0e4

test case for unit test

Ok, I've attached a unit test which sets up a set of routes for the /as/:a_id/bs/:b_id/cs/:c_id/ds/:id path in a similar way to a set of nested map.resources calls. It then uses the named route methods to generate a couple of routes with objects passed as parameters. The first assertion in the test fails because the URL generated is incorrect. The second assertion fails because the routing modules raises an exception.

Ok, I totally misunderstood before -- thanks for the test case. :-)

We need to decide if reversing the order is a special case, or if all positional parameters ought to be in reversed order.

I suspect the former is more the case. If so, then we can add support for an explicit order to be provided. Then we can update the resources call to specify whatever order we feel makes sense for simply restful.

Jamis -- does this sound good?

Bump!