Ticket Navigation

Ticket #6481 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Object.extend problem in Firefox 2.0 RC3

Reported by:	mytto	Assigned to:	sam
Priority:	high	Milestone:	1.x
Component:	Prototype	Version:	edge
Severity:	blocker	Keywords:	regression
Cc:

Attachments

Test case for Object.extend.zip (12.1 kB) - added by mytto on 10/24/06 19:05:02.: Test case
ObjectTest.html (1.1 kB) - added by lukem on 10/25/06 05:41:28.: Standalone test case

Change History

(in reply to: ↑ 2 ; follow-up: ↓ 4 ) 10/25/06 20:37:17 changed by lukem

In case anyone is really desperate for a workaround... you can change Object to Obj and Function to Func and then modify all the prototype.js code to manually call things like call Obj.extend(...) and Func.bind(function(){},someObj). This is really invasive of course and kind of sucks.

Here are the modified Obj and Func objects:

Obj = {
  extend: function(destination, source) {
    for (var property in source) {
      destination[property] = source[property];
    }
    return destination;
  },

  inspect: function(object) {
    try {
      if (object == undefined) return 'undefined';
      if (object == null) return 'null';
      return object.inspect ? object.inspect() : object.toString();
    } catch (e) {
      if (e instanceof RangeError) return '...';
      throw e;
    }
  },

  keys: function(object) {
    var keys = [];
    for (var property in object)
      keys.push(property);
    return keys;
  },

  values: function(object) {
    var values = [];
    for (var property in object)
      values.push(object[property]);
    return values;
  },

  clone: function(object) {
    return Obj.extend({}, object);
  }
}

Func = {
  bind: function() {
    var args = $A(arguments), __method = args.shift(), object = args.shift();
    return function() {
      return __method.apply(object, args.concat($A(arguments)));
    }
  },

  bindAsEventListener: function(object) {
    var args = $A(arguments), __method = args.shift(), object = args.shift();
    return function(event) {
      return __method.apply(object, [( event || window.event)].concat(args).concat($A(arguments)));
    }
  }
}

Then you have to do a ton of search and replaces like

Object.extend => Obj.extend
foo.bind(bar) => Func.bind(foo, bar)
foo.bindAsEventListener(bar) => Func.bindAsEventListener(foo, bar)

This workaround totally sucks. But it may be better than nothing. Anyone have any better ideas? :-)

(in reply to: ↑ 3 ) 10/26/06 15:02:20 changed by mytto

Replying to lukem:

In case anyone is really desperate for a workaround... you can change Object to Obj and Function to Func and then modify all the prototype.js code to manually call things like call Obj.extend(...) and Func.bind(function(){},someObj). This is really invasive of course and kind of sucks.

The issue there is to recode all prototype.js derived code also, e.g. Scriptaculous, Rico, ..., as well as your own prototypish scripts.

I have a slightly better, far less invasive workaround that seems to work (I still need further testing, but yet it runs). The overall idea is to redeclare the missing stuff just after page loading, i.e. as after body.onload event.

Here's what you should do:

1. create a javascript file like this one

/**
 * Hack for Firefox 2.0 bug
 *
 * Bug causes Object and Function object to be emptied 
 * when opening a new window
 */
 
ObjectInitialisation = {
  // Function to be launched during body.onload event
  hackIt : function() {
  
    if (Object.extend) {
      return;
    }

    Object.extend = function(destination, source) {
      for (property in source) {
        destination[property] = source[property];
      }
      return destination;
    }

    Object.inspect = function(object) {
      try {
        if (object == undefined) return 'undefined';
        if (object == null) return 'null';
        return object.inspect ? object.inspect() : object.toString();
      } catch (e) {
        if (e instanceof RangeError) return '...';
        throw e;
      }
    }
	
    ...
}

2. In the HTML file, add a body.onload handler

<body onload="ObjectInitialisation.hackIt()">
...

Download in other formats:

Rails Trac

Ticket Navigation

Ticket #6481 (closed defect: fixed)

Object.extend problem in Firefox 2.0 RC3

Description

Attachments

Change History

10/24/06 19:05:02 changed by mytto

(in reply to: ↑ description ) 10/25/06 05:40:05 changed by lukem

10/25/06 05:41:28 changed by lukem

(follow-up: ↓ 3 ) 10/25/06 08:02:31 changed by mytto

(in reply to: ↑ 2 ; follow-up: ↓ 4 ) 10/25/06 20:37:17 changed by lukem

(in reply to: ↑ 3 ) 10/26/06 15:02:20 changed by mytto

(follow-up: ↓ 6 ) 10/26/06 15:07:45 changed by mytto

(in reply to: ↑ 5 ; follow-up: ↓ 7 ) 10/26/06 16:33:16 changed by DavidPodolsky

(in reply to: ↑ 6 ; follow-up: ↓ 8 ) 10/26/06 22:27:33 changed by lukem

(in reply to: ↑ 7 ) 10/27/06 07:08:58 changed by mytto

03/06/07 11:06:54 changed by bitsweat

Download in other formats: