Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #6379 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[PATCH] Clean up the new cleaner error pages

Reported by: toolmantim Assigned to: David
Priority: normal Milestone: 1.2
Component: Railties Version: edge
Severity: normal Keywords: tiny
Cc:

Description

The pages in committed in [5279] might have fixed exteme visual ugliness, but they introduced some extreme code ugliness with invalid html and confused styles.

Attached is a patch with cleaner versions of the two pages.

Attachments

rails_cleaner_error_pages.diff (3.5 kB) - added by toolmantim on 10/11/06 06:41:25.
rails_cleaner_error_pages_v2.diff (3.5 kB) - added by toolmantim on 10/15/06 22:53:47.
New patch. Fixed CSS name to "sans-serif", not "san-serif"

Change History

10/11/06 06:41:25 changed by toolmantim

  • attachment rails_cleaner_error_pages.diff added.

10/15/06 22:53:47 changed by toolmantim

  • attachment rails_cleaner_error_pages_v2.diff added.

New patch. Fixed CSS name to "sans-serif", not "san-serif"

10/15/06 23:32:30 changed by nzkoz

  • status changed from new to closed.
  • resolution set to fixed.

(In [5306]) Tidy up the markup on the bundled error pages. Closes #6379. [Tim Lucas]