Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #6372 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[PATCH] continuous buiilder mail notifier broken when campfire changes went in

Reported by: rsanheim Assigned to: David
Priority: normal Milestone: 1.x
Component: Railties Version: edge
Severity: normal Keywords: patch continous builder tiny
Cc: rsanheim@gmail.com

Description

Continuos Builder was broken when Campfire support was added a little while ago (see: http://dev.rubyonrails.org/changeset/5222) - the options hashes were renamed in the rake task to "campfire_notice_options" and "mail_notice_options", but the actual calls to MailNotifier weren't changed to use the mail_notice_options hash.

Patch is attached that fixes the calls to use the correct hash. Very simple change, no tests needed (and there aren't any for cont. builder anyways =) )

Attachments

fix_mail_notifier.diff (1.3 kB) - added by rsanheim on 10/10/06 08:32:58.
fix the hashes

Change History

10/10/06 08:32:58 changed by rsanheim

  • attachment fix_mail_notifier.diff added.

fix the hashes

10/10/06 08:33:22 changed by rsanheim

  • cc set to rsanheim@gmail.com.

10/10/06 08:43:15 changed by rsanheim

  • keywords changed from patch continous builder to patch continous builder tiny.

10/10/06 18:38:05 changed by david

  • status changed from new to closed.
  • resolution set to fixed.

(In [5280]) Fix mailer for CB (closes #6372)