Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #6346 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

[PATH] Strip Marshal file versioning and adding bytes cleaning

Reported by: manfred Assigned to: David
Priority: normal Milestone: 1.2
Component: ActiveSupport Version: edge
Severity: normal Keywords: multibyte
Cc:

Description

In the flurry of multibyte patches the versions got mixed up and and slightly older patch was merged.

I was under the assumption that we needed marshal file versioning because 1.8.5 couldn't read 1.8.4 marshal files, but this was a windows problem with binary files. This patch removes the two versions of the unicode tables. Please replace them with the one provided. 

D      lib/active_support/values/unicode_tables-1.8.4.dat
D      lib/active_support/values/unicode_tables-1.8.5.dat

This patch also adds bytes cleaning when someone tries to perform operations on not fully utf-8 string. CP1252 or ISO-8858-I can be mixed with utf-8 when pasted from certain Microsoft applications.

Attachments

multibyte_marshal_and_tidy_bytes.diff (7.3 kB) - added by manfred on 10/04/06 08:50:30.
multibyte_unicode_tables.tar.gz (128.3 kB) - added by manfred on 10/04/06 08:50:50.

Change History

10/04/06 08:50:30 changed by manfred

  • attachment multibyte_marshal_and_tidy_bytes.diff added.

10/04/06 08:50:50 changed by manfred

  • attachment multibyte_unicode_tables.tar.gz added.

10/04/06 09:03:58 changed by nzkoz

  • status changed from new to closed.
  • resolution set to fixed.

(In [5224]) Pull in latest multibyte patch. Closes #6346 [Manfred Stienstra]