Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #6257 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[PATCH] caches_action breaks with file extensions

Reported by: Catfish Assigned to: David
Priority: normal Milestone: 1.2
Component: ActionPack Version: edge
Severity: major Keywords: fp caches_action extensions
Cc:

Description

r5129 broke file extensions for cached actions.

eg trying to access /graphs/show/1.png would raise an exception - "undefined method `content_type=' for #<GraphsController:0x2595ed8>"

The fix is trivial - caching.rb:213 is trying to set the content type on the controller, rather than the response. Tests demonstrating this and the fix are included.

Attachments

fix_content_type_for_file_extensions.diff (1.2 kB) - added by Catfish on 09/21/06 16:36:17.
Fix for file extensions & cached actions

Change History

09/21/06 16:36:17 changed by Catfish

  • attachment fix_content_type_for_file_extensions.diff added.

Fix for file extensions & cached actions

09/21/06 16:44:18 changed by bitsweat

  • keywords changed from caches_action extensions to fp caches_action extensions.
  • milestone changed from 1.x to 1.2.

10/09/06 00:56:13 changed by david

  • status changed from new to closed.
  • resolution set to fixed.

(In [5248]) Fixed that caches_action breaks with file extensions (closes #6257) [Catfish]