[PATCH] alias_method_chain does not support setter methods (foo=)

er... will post the patch when there's space left on the device.

In case I forget, better have it here:

Index: test/core_ext/module_test.rb
===================================================================
--- test/core_ext/module_test.rb	(revision 5086)
+++ test/core_ext/module_test.rb	(working copy)
@@ -114,6 +114,10 @@
   def quux_with_baz?
     false
   end
+  
+  def quux_with_baz=(v)
+    @quux = v + 1
+  end
 end
 
 class MethodAliasingTest < Test::Unit::TestCase
@@ -161,19 +165,27 @@
   def test_alias_method_chain_with_same_names_between_predicates_and_bang_methods
     FooClassWithBarMethod.send(:define_method, 'quux!', Proc.new { 'quux' })
     FooClassWithBarMethod.send(:define_method, 'quux?', Proc.new { true })
+    FooClassWithBarMethod.send(:define_method, 'quux=', Proc.new { |v| @quux = v })
+    @instance.quux = 2
     assert !@instance.respond_to?(:quux_with_baz!)
     assert !@instance.respond_to?(:quux_with_baz?)
+    assert !@instance.respond_to?(:quux_with_baz=)
+    assert_equal 2, @instance.instance_variable_get("@quux")
 
     FooClassWithBarMethod.send(:include, BarMethodAliaser)
     FooClassWithBarMethod.alias_method_chain :quux!, :baz
     FooClassWithBarMethod.alias_method_chain :quux?, :baz
+    FooClassWithBarMethod.alias_method_chain :quux=, :baz
+    @instance.quux = 3
 
     assert @instance.respond_to?(:quux_with_baz!)
     assert @instance.respond_to?(:quux_with_baz?)
+    assert @instance.respond_to?(:quux_with_baz=)
     assert_equal 'quux_with_baz!', @instance.quux!
     assert_equal 'quux', @instance.quux_without_baz!
     assert_equal false, @instance.quux?
     assert_equal true,  @instance.quux_without_baz?
+    assert_equal 4, @instance.instance_variable_get("@quux")
   end
 
   def test_alias_method_chain_with_feature_punctuation
Index: lib/active_support/core_ext/module/aliasing.rb
===================================================================
--- lib/active_support/core_ext/module/aliasing.rb	(revision 5086)
+++ lib/active_support/core_ext/module/aliasing.rb	(working copy)
@@ -23,7 +23,7 @@
   def alias_method_chain(target, feature)
     # Strip out punctuation on predicates or bang methods since
     # e.g. target?_without_feature is not a valid method name.
-    aliased_target, punctuation = target.to_s.sub(/([?!])$/, ''), $1
+    aliased_target, punctuation = target.to_s.sub(/([?!=])$/, ''), $1
     alias_method "#{aliased_target}_without_#{feature}#{punctuation}", target
     alias_method target, "#{aliased_target}_with_#{feature}#{punctuation}"
   end

I would like to see this added to core. This is annoying to have to work around and I've ended up doing it a lot in my models to overload assignment methods for attributes.

Patch works excellently for me and I'd love to see this added.

Edit to above: Not so much for attribute assignments but for association assignment methods.

patch

(In [5091]) alias_method_chain works with accessor= methods also. Closes #6153.