Problem with dependencies and plugins

Curious - as a shot in the dark, could you try changing the plugin directory name so it doesn't clash with the module name?

Also, set Dependencies.log_activity = true and watch the log at plugin load time.

Hi Jeremy - I'll give that a go tomorrow. You think perhaps a problem is being caused by it trying to look in /unobtrusive_javascript/unobtrusive_javascript?

acts_as_paranoid and acts_as_attachment load correctly on the first request. Subsequent requests fail after that with:

./script/../config/../vendor/rails/activesupport/lib/active_support/dependencies.rb:186:in `load_missing_constant': A copy of Technoweenie::ActsAsAttachment::ActMethods has been removed from the module tree but is still active!

Personally I don't see the need to make plugins reloadable like the rest of rails in dev mode. But I suppose for plugin developers is is a nice feature.

Having plugins reloadable in development is certainly convenient, but I'd take a working dependencies system with server restarts for plugin changes over reloadable plugins.

luke: unobtrusive js seems to work fine for me, but I'm not doing much with it. Could you offer some assistance reproducing it on latest trunk?

I'm having the same problem with a few other plugins (most notably auto-admin) where it's reloading the AutoAdmin::Configuration module with each request. Any way to mark as a module as not reloadable?

(In [4837]) Update Initializer to use load_once_paths to avoid plugin reloading. References #5852. Add Dependencies.load_once_paths.

Mephisto and all its wonderful plugins work fine. I'm closing for now. Please reopen if you still have this issue.

OK, there was still a problem with the UJS plugin, which *may* need looking at. However I'll leave the ticket closed for now as I was able to come up with a simple workaround.

The UJS plugin is in vendor/plugins/unobtrusive_javascript; it uses a module called UnobtrusiveJavascript which is first created in PLUGIN_ROOT/lib/unobtrusive_javascript.rb and contains other files inside the module in PLUGIN_ROOT/lib/unobtrusive_javascript/ - this seemed to confuse Rails for some reason.

I was able to fix things by renaming the module throughout the plugin to UJS, renaming lib/unobtrusive_Javascript.rb to lib/ujs.rb and lib/unobtrusive_Javascript/ to lib/ujs. All now seems to be fine.

I experience a problem with the acts_as_authenticated plugin mechanism. The problem is actually not with the plugin but with the resulting library that it creates, lib/authenticated_system.rb and reloading of modules when testing via script/console. (I cannot recreate the problem in development against script/server.)

I get the error, ArgumentError (A copy of AuthenticatedSystem has been removed from the module tree but is still active!):

In dependencies.rb, the call to qualified_const_defined? inside the load_missing_constant method reports that AuthenticatedSystem is still hanging around. Looking at the development log reveals that it has indeed been removed (or at least reports that it has been removed): Dependencies: removing constant AuthenticatedSystem

config.load_once_paths apparently needs to be set in environment.rb itself; it can't be set in, say, environment/test.rb where it might be more useful. Is that intended behavior?

vinbarnes@gmail.com: Can you please open a new ticket, since this appears to be a different issue?

Also, ApplicationController was not reloading properly, so it may have been causing these problems. It was fixed in [4910].

Jay: You can probably manipulate Dependencies.load_paths directly; however it's probably not a good idea to encourage that.

The main problem with people doing so is that load_paths and load_once_paths ought to be uniq -- Perhaps we should replace config.autoload_paths and config.load_once_paths with something like this:

class UniqEnumerableProxy
  include BlankSlate
  
  def initialize(delegate)
    @delegate = delegate
  end
    
  def method_missing(selector, *args, &proc)
    result = @delegate.send(selector, *args, &proc)
    @delegate.uniq!
    return result
  end
  
  def respond_to?(selector)
    @delegate.respond_to? selector
  end 
  
end

Closing; open new tickets for new issues.

This may work now in the sense that it doesn't crash, but it's a real pain for me to not be able to have my plugin code reloadable. Why not allow plugins to specify if they want to have all their code reloadable in the init.rb?