Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #5802 (new defect)

Opened 2 years ago

Last modified 1 year ago

Sortable Lists crashing Safari again

Reported by: matt@indielabs.com Assigned to: thomas@fesch.at
Priority: normal Milestone:
Component: script.aculo.us Version:
Severity: major Keywords:
Cc: markus.fassbender@gmail.com

Description

Looks like the new V 1.6.2 has brought this bad boy back to life: http://dev.rubyonrails.org/ticket/2310

I rolled back to an older version and it was fixed.

Change History

06/06/07 16:43:40 changed by Fasse

  • cc set to markus.fassbender@gmail.com.
  • owner changed from thomas@fesch.at to Fasse.
  • status changed from new to assigned.
  • severity changed from normal to major.

I could confirm this bug with script.aculo.us version 1.7.0 and Safari 2.0.4 on MacOS 10.4.9 .

I put a test-case on http://spielwiese.admidio.org/fields2.php. Pick one of the small green arrows and try to move them up or down. Safari crashs immediately. Firefox on Win & MacOS and IE 6 & 7 work as expected.

This is a sortable list in a table so there are some other issues in the other browsers, but not a crash

06/06/07 16:45:13 changed by Fasse

  • owner changed from Fasse to thomas@fesch.at.
  • status changed from assigned to new.

Sorry, I don't want to assign this bug :(

06/08/07 09:42:51 changed by madrobby

Seems like it's related to table elements, which aren't supported for drag and drop or effects: 

Thread 0 Crashed:
0   com.apple.WebCore              	0x95eddc74 khtml::RenderBlock::insertPositionedObject(khtml::RenderObject*) + 32
1   com.apple.WebCore              	0x95e527ec khtml::RenderBlock::layoutInlineChildren(bool) + 712
2   com.apple.WebCore              	0x95e4f4d4 khtml::RenderBlock::layoutBlock(bool) + 692
3   com.apple.WebCore              	0x95e52500 khtml::RenderTableCell::layout() + 44
4   com.apple.WebCore              	0x95e5248c khtml::RenderTableRow::layout() + 140
5   com.apple.WebCore              	0x95e523d4 khtml::RenderContainer::layout() + 92
6   com.apple.WebCore              	0x95e51090 khtml::RenderTable::layout() + 396
7   com.apple.WebCore              	0x95e4ffac khtml::RenderBlock::layoutBlockChildren(bool) + 696
8   com.apple.WebCore              	0x95e4f4ec khtml::RenderBlock::layoutBlock(bool) + 716
9   com.apple.WebCore              	0x95e4ffac khtml::RenderBlock::layoutBlockChildren(bool) + 696
10  com.apple.WebCore              	0x95e4f4ec khtml::RenderBlock::layoutBlock(bool) + 716
11  com.apple.WebCore              	0x95e4ffac khtml::RenderBlock::layoutBlockChildren(bool) + 696
12  com.apple.WebCore              	0x95e4f4ec khtml::RenderBlock::layoutBlock(bool) + 716
13  com.apple.WebCore              	0x95e4ffac khtml::RenderBlock::layoutBlockChildren(bool) + 696
14  com.apple.WebCore              	0x95e4f4ec khtml::RenderBlock::layoutBlock(bool) + 716
15  com.apple.WebCore              	0x95e4c24c khtml::RenderCanvas::layout() + 248

If anyone can isolate this issue, I'm glady accepting a patch!

06/08/07 12:51:26 changed by Fasse

Yes I know that Sortables aren't supported in table elements. But beside of this a crash of a browser is not good. Maybe a problem of the browser, but maybe the crash could be fix in scriptaculous.

Beside this the demo works perfect in IE7, nearly perfekt in IE6 and usable with Firefox.

06/11/07 21:29:44 changed by Fasse

I tested it with Safari 3.0 Beta and there isn't a crash. Also the drag and drop in table is working. Not perfect, but it works :)