Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #5706 (closed defect: wontfix)

Opened 3 years ago

Last modified 3 years ago

The colon meaning `then' seems to be obsoleted.

Reported by: yanagi@shakenbu.org Assigned to: David
Priority: normal Milestone:
Component: ActiveRecord Version:
Severity: normal Keywords:
Cc:

Description

With the latest Ruby in the 1.8 branch (including 1.8.5 preview 2), the colon meaning `then' seems to be obsoleted.

http://www.ruby-lang.org/cgi-bin/cvsweb.cgi/ruby/parse.y.diff?r1=1.307.2.36;r2=1.307.2.37 

% /var/tmp/ruby/bin/ruby -v
ruby 1.8.5 (2006-07-23) [i686-linux]
% /var/tmp/ruby/bin/ruby -v script/server
ruby 1.8.5 (2006-07-23) [i686-linux]
./script/../config/../vendor/rails/activesupport/lib/active_support/inflector.rb:170: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activesupport/lib/active_support/inflector.rb:171: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activesupport/lib/active_support/inflector.rb:172: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activesupport/lib/active_support/json/encoders/core.rb:24: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activesupport/lib/active_support/json/encoders/core.rb:25: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activesupport/lib/active_support/json/encoders/core.rb:26: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activesupport/lib/active_support/json/encoders/core.rb:27: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activesupport/lib/active_support/json/encoders/core.rb:28: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activesupport/lib/active_support/json/encoders/core.rb:29: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activesupport/lib/active_support/json/encoders/core.rb:30: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activesupport/lib/active_support/json/encoders/core.rb:31: warning: colon will be obsoleted; use semicolon
=> Booting WEBrick...
./script/../config/../vendor/rails/activerecord/lib/active_record/base.rb:1900: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activerecord/lib/active_record/base.rb:1901: warning: colon will be obsoleted; use semicolon
./script/../config/../vendor/rails/activerecord/lib/active_record/base.rb:1902: warning: colon will be obsoleted; use semicolon
(snip)

Attachments

colon_fix.diff (6.7 kB) - added by bmitchell@backchannelmedia.com on 08/19/06 23:48:03.
Swap out warned colons for semi-colons in rev. 4791

Change History

08/19/06 23:48:03 changed by bmitchell@backchannelmedia.com

  • attachment colon_fix.diff added.

Swap out warned colons for semi-colons in rev. 4791

08/19/06 23:52:52 changed by bmitchell@backchannelmedia.com

I've posted a quick patch that I maintain in my darcs mirror of rails. This seems to remove all warnings for me when loading the development environment for script/console and script/server. The current fix just swaps out colons for semi-colons. I would recommend the patch be applied and the style issues be decided after so those of us who are running on 1.8.5+ can avoid -W0 or 2> /dev/null.

08/20/06 03:51:00 changed by court3nay

A discussion took place on the core list about this idea about a month ago and nothing came of it since several of them disagree in principle with the semicolon. Maybe you'll have better luck.

08/30/06 03:44:30 changed by bitsweat

  • status changed from new to closed.
  • resolution set to wontfix.

09/03/06 03:25:32 changed by anonymous

curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl curl