Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #5097 (closed enhancement: wontfix)

Opened 3 years ago

Last modified 3 years ago

[PATCH] Including "aircraft" in inflect.uncountable

Reported by: hcatlin@gmail.com Assigned to: David
Priority: normal Milestone:
Component: ActiveSupport Version:
Severity: minor Keywords: tiny inflect
Cc:

Description

Adding the word "aircraft" to the uncountable list in ActiveSupport.

Small change, added to the tests for activesupport.

Assuming this should be tagged tiny since there isn't much to break with simply adding a inflector fix.

Attachments

inflection_of_aircraft.diff (0.8 kB) - added by hcatlin@gmail.com on 05/16/06 16:10:19.
Proposed patch.

Change History

05/16/06 16:10:19 changed by hcatlin@gmail.com

  • attachment inflection_of_aircraft.diff added.

Proposed patch.

05/16/06 16:52:25 changed by bitsweat

  • status changed from new to closed.
  • resolution set to wontfix.

Rather than change the Inflector rule set, the way to bend the Inflector to do your bidding is to add your own custom rules to the bottom of your config/environment.rb file. See the commented out section for adding custom Inflector rules.

05/16/06 17:48:10 changed by pete@unspace.ca

Aircrafts is not a word.

It doesn't seem like declaring it as uncountable is a customization.

05/18/06 01:11:20 changed by hcatlin@gmail.com

  • status changed from closed to reopened.
  • resolution deleted.

Today I read the 37Signals blog post by David about how blanket policies should be questioned.

I realized that "fish" and "sheep" were two of the entries listed as irregular; however, I find that the likelihood of someone making a Fish or Sheep model far less than that of an Aircraft. I don't believe that every single possible irregular word should be listed. I think the issue of maintaining a short and useful list *is* worth periodic attention.

I'm certainly not trying to create conflict or be a troll, it just seems an imbalanced list as it stands.

Would it be appropriate to volunteer to create an updated list to reflect usage in real world applications?

05/18/06 01:32:07 changed by dpiddy@gmail.com

That might make a cool plugin. You might run into the same "what makes it in?" problem with it, though.

05/18/06 02:30:26 changed by kevinclark

  • status changed from reopened to closed.
  • resolution set to wontfix.

Inflections are officially closed at the moment. If you like a reorg, I suggest you discuss it on the core list. For this particular problem, see http://weblog.rubyonrails.org/articles/2006/05/17/gentle-reminder-pluralizations