[PATCH] HTTP methods "GET"/"POST" should be uppercase

Weblogic and Tomcat accept "POST" and "GET", in upper case; I guess new browsers convert them, but ie 5.5 don't.

No closing without explanation.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.1 specifies the request method has to be uppercase.

Martin -

the spec does not say it has to be uppercase: it says that the method is case sensitive and that the authors have chosen to uppercase the standard verbs.

this means that post != POST != PoST

but it also means that you should be able to handle POST and post seperately, and that a server may well indeed intend to. A good example of this is a secured / hardened hacked server, which has POST for untrusted input, and post for trusted input, or a server that uses POST for form submission but post for API requests.

This is an unusual use, and granted misguided - the potential for confusion is high - and so I do support the use of only uppercase verbs where the verb is predefined (such as GET,POST,PUT,etc)

a recurrent problem is that because authors are getting this confused, and there is case sensitivity (often a bad idea) browser and server authors have tended to ignore and interpret the action themselves - some browsers convert to uppercase, some servers match insensitively. Therefore the patch attached seems bogus - it doesn't understand that POST != post - but so many authors get this wrong too, that fixing it properly is also not possible.

I vote to just make the following patch to change the method -

9 - method: 'post', 10 + method: 'POST',

and forget about making the comparisons case sensitive - it makes assumptions that we should not be making.

And 'GET'? Authors will always write 'POST' and 'GET' in their code and

18 - if (this.options.method == 'get' && parameters.length > 0) 19 + if (this.options.method == 'GET' && parameters.length > 0)

33 - this.transport.send(this.options.method == 'post' ? body : null); 33 + this.transport.send(this.options.method == 'POST' ? body : null);

42 - if (this.options.method == 'post') { 43 + if (this.options.method == 'POST') {

without back compatibility with older versions of Prototype, is it correct? Sorry for my (bad) English!

Nicola

Related to #4656.

This ticket is now superseded by #6366.

Closing this in favor of big patch in #6366

In it, HTTP method case is handled (internally) in lowercase, and is uppercased prior to opening a connection. User can specify it in uppercase also; doesn't change things.