Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #4271 (new defect)

Opened 2 years ago

Last modified 10 months ago

[PATCH] continuous_builder plugin, add success notification option plus safer BIN_PATH

Reported by: tim@sbrew.com Assigned to: David
Priority: normal Milestone:
Component: Plugins Version: 1.0.0
Severity: normal Keywords: continuous builder plugin
Cc:

Description

This patch addresses two issues:

# It allows a success message to be sent if the :options/ENV contains a "NOTIFY_ON_SUCCESS". Currently it only notifies on failures, or fixes. # It allows a BUILD_PATH to be specified *without* a trailing /. This part of the patch might save other folks some time -- it took us quite a while to track it down.. Our rake was installed in /usr/bin, and it turns out we had specified BUILD_PATH=/usr/bin in our subversion post-commit hook when it was expecting BUILD_PATH=/usr/bin/.

This patch was a team effort with my colleague Lori Olson.

There were no test cases provided with this plugin, so unfortunately none were added with this patch.

Attachments

continuous_builder_add_happy_notification.diff (2.0 kB) - added by tim@sbrew.com on 03/16/06 23:14:21.
Diff file for patch
continuous_builder_add_happy_notification.2.diff (2.2 kB) - added by tim@sbrew.com on 03/16/06 23:15:44.
patch file for ticket (full pathnames in this one)
continuous_buider_add_happy_notification.2.diff (2.2 kB) - added by tim@sbrew.com on 03/24/06 20:37:02.
The previous patch didn't work without an explicit BIN_PATH

Change History

03/16/06 23:14:21 changed by tim@sbrew.com

  • attachment continuous_builder_add_happy_notification.diff added.

Diff file for patch

03/16/06 23:15:44 changed by tim@sbrew.com

  • attachment continuous_builder_add_happy_notification.2.diff added.

patch file for ticket (full pathnames in this one)

03/16/06 23:52:21 changed by Lori Olson <lori@ltx.ca>

  • summary changed from [PATCH] continuous_builder plugin, add success notification option plus safer BUILD_PATH to [PATCH] continuous_builder plugin, add success notification option plus safer BIN_PATH.

Oops, we meant BIN_PATH, not BUILD_PATH.

03/24/06 20:37:02 changed by tim@sbrew.com

  • attachment continuous_buider_add_happy_notification.2.diff added.

The previous patch didn't work without an explicit BIN_PATH

11/06/06 18:26:26 changed by jgarber

I got on to log the same bug. Please apply the patch soon.

04/25/07 03:19:01 changed by josh

  • keywords changed from continuous builder plugin to continuous builder plugin unverfied.

04/25/07 03:19:58 changed by josh

  • keywords changed from continuous builder plugin unverfied to continuous builder plugin unverified.

05/26/07 03:20:31 changed by tpope

  • component changed from ActionPack to Plugins.

07/19/07 23:30:05 changed by lifofifo

  • keywords changed from continuous builder plugin unverified to continuous builder plugin.