Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #4230 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[PATCH] Oracle bug fixes

Reported by: mschoen Assigned to: David
Priority: normal Milestone:
Component: ActiveRecord Version: 1.0.0
Severity: normal Keywords: needs_review
Cc:

Description

Patch contains a few bug fixes, collected from a few open tickets, into a single patch.

  • Changes :text to CLOB rather than BLOB [Moses Hohman]
  • Fixes an issue with nil numeric length/scales (several)
  • Implements support for XMLTYPE columns [wilig / Kubo Takehiro]
  • Tweaks a unit test to get it all green again
  • Adds support for #current_database, refs #3663

Closes #4181, #4225, #3562.

Attachments

oracle.patch (4.0 kB) - added by mschoen on 03/14/06 08:57:52.
oracle2.patch (4.0 kB) - added by mschoen on 03/15/06 22:43:12.
revised patch
oracle3.patch (3.9 kB) - added by mschoen on 03/15/06 23:01:12.
revised patch (again)

Change History

03/14/06 08:57:52 changed by mschoen

  • attachment oracle.patch added.

03/14/06 18:24:54 changed by jay@thoughtworks.com

we're going to try this.

03/14/06 19:15:10 changed by jay@thoughtworks.com

The patch did not fix our float issue.

03/14/06 20:12:35 changed by mschoen

Are you sure you applied the patch properly? With the patch applied, it passes the test including on #4225.

03/14/06 21:04:30 changed by mschoen

Spoke with Jay by email, his issue is one with migrations, not specifically with the Oracle implementation (looking for support for the :scale option). Shouldn't hold up the application of this patch.

03/14/06 21:20:00 changed by jay@thoughtworks.com

Agree with Michael, my issue should not hold using this patch. I misunderstood "Fixes an issue with nil numeric length/scales" to mean that it should address my issue. Sorry.

03/14/06 22:20:29 changed by mschoen

  • keywords set to needs_review.

03/15/06 02:26:17 changed by atmos@atmos.org

I'll see about testing these tomorrow at work.

03/15/06 22:43:12 changed by mschoen

  • attachment oracle2.patch added.

revised patch

03/15/06 22:48:01 changed by mschoen

Uploaded new patch, since base_test.rb has been updated in the interim.

03/15/06 23:01:12 changed by mschoen

  • attachment oracle3.patch added.

revised patch (again)

03/16/06 03:21:07 changed by david

  • status changed from new to closed.
  • resolution set to fixed.

Fixed by [3889]