Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #4017 (closed defect: duplicate)

Opened 2 years ago

Last modified 2 years ago

[PATCH] Rename oracle_adapter, keep up w/ the Joneses

Reported by: mschoen Assigned to: David
Priority: high Milestone: 1.1
Component: ActiveRecord Version: 1.0.0
Severity: normal Keywords:
Cc: schoenm@earthlink.net

Description

The attached patch renames the Oracle adapter from "oci" to "oracle", retaining full backwards compatibility for all those folks currently referencing it as "oci".

To use the adapter with it's new name, simply change your database.yml file to include: 

  adapter: oracle
  database: <your db name here>

Note that database is now used instead of host.

Also includes the following:

  • supports Rails app generation with the --database=oracle option
  • adds support for #disconnect!
  • includes the fix from #4010 for :text datatype

Before applying the patch, several files must be removed or renamed in the repository. The required commands are: 

  cd trunk/activerecord/lib/active_record/connection_adapters/
  svn mv oci_adapter.rb oracle_adapter.rb

  cd trunk/activerecord/test/connections/
  svn rm native_oci/connection.rb
  svn rm native_oci

  cd trunk/activerecord/test/fixtures/db_definitions/
  svn rm create_oracle_db.sh
  svn mv oci.drop.sql oracle.drop.sql
  svn mv oci.sql oracle.sql
  svn mv oci2.drop.sql oracle2.drop.sql
  svn mv oci2.sql oracle2.sql

  cd trunk/activerecord/test/
  svn mv synonym_test_oci.rb synonym_test_oracle.rb

After this is done, the patch should apply cleanly.

Attachments

oracle_adapter.patch (21.0 kB) - added by anonymous on 03/01/06 07:21:08.
database_rake.patch (1.7 kB) - added by mschoen on 04/29/06 20:50:26.

Change History

03/01/06 07:21:08 changed by anonymous

  • attachment oracle_adapter.patch added.

03/01/06 16:01:59 changed by david

  • status changed from new to closed.
  • resolution set to fixed.

(In [3718]) Renamed the "oci" adapter to "oracle", but kept the old name as an alias (closes #4017) [schoenm@earthlink.net]

03/01/06 18:26:38 changed by anonymous

  • status changed from closed to reopened.
  • resolution deleted.

Thanks for the quick turnaround. Not critical, but I missed a file to remove (really old (and empty)) .bat script. Can you remove this? 

  svn rm activerecord/test/fixtures/db_definitions/create_oracle_db.bat

Thanks!

03/02/06 02:54:35 changed by david

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [3742]) No longer needed (closes #4017)

04/29/06 07:36:38 changed by dumpingrounds@gmail.com

  • status changed from closed to reopened.
  • resolution deleted.

making the change in database.yml from "oci" to "oracle" as directed above causes rake db:structure:dump to fail with the error message Task not supported by 'oracle'. Changing it back to "oci", the task runs normally.

Other db-related tasks, such as db:schema:import, seem to be working fine with the "oracle" entry in database.yml

04/29/06 20:50:26 changed by mschoen

  • attachment database_rake.patch added.

04/29/06 20:51:12 changed by mschoen

Thanks, I've added a second patch to this ticket that adds support for "oracle" to the database rake tasks.

05/21/06 07:19:58 changed by mschoen

  • cc set to schoenm@earthlink.net.
  • status changed from reopened to closed.
  • resolution set to duplicate.

The database rake patch has been incorporated into #5139.

07/25/06 03:46:34 changed by anonymous

mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang mushang