layout inheritance broken with :only

This bug still exists in 1.1.4 and occurs even for layouts specified in the same file. I discovered it when I had no explicit layouts (just using "application" implicitly) and I added the following for the splash page of the site:

layout nil, :only => :index

Which resulted in all of that controller's actions using no layout.

A workaround attempt failed:

layout nil, :only => :index
layout "application"

However if I made the layout specification explicit (using :only, not :except) in a second declaration after the first one then it works:

layout nil, :only => :index
layout "application", :only => [:school, :salon, :contact]

I would love to get inside Rails and create a patch for this, but I'm on a time constraint. I think this is big enough that it should be fixed for the next version. I also expect it's a pretty easy fix.

Same problem still exists in 1.1.6. This is a serious problem so I'm up'ing the priority.

Still exists in 1.2!

It seems to be in this block ActionController::Layout line 293

      def action_has_layout?
        if conditions = self.class.layout_conditions
          case
            when only = conditions[:only]
              only.include?(action_name)
            when except = conditions[:except]
              !except.include?(action_name) 
            else
              true
          end
        else
          true
        end
      end

Basically, if an only exists, and this action isn't in it, set action_has_layout? to false. I tested that this is where the bug is by returned true, but haven't created tests or a patch.

Of course - it's a quite a bit more complicated than that, but that's the most obvious entry point to the bug.

Test case showing bug in handling of layout :only with layout :except

I ran into a very similar problem, except I wasn't even using inheritance. There seems to be a bug in the handling of :only and :except layouts. For example, if you have a controller Foo, and you want action "a" to use layout "foo", and action "b" to use layout "bar", then you might add something like this to Foo:

  layout "foo", :only => :a
  layout "bar", :except => :a

But this does not work as expected. Action "a" gets layout "bar", and action "b" gets no layout at all!

I've attached a test case showing the problem on Rails 1.2.3. To reproduce, start the server and go to http://localhost:3000/foo/a and http://localhost:3000/foo/b

Actually, the issue I just reported seems to be a duplicate of #8867.