Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #3371 (closed defect: wontfix)

Opened 3 years ago

Last modified 3 years ago

[PATCH] mysql adapter incorrectly quotes column names containing a backtick

Reported by: JohnDouthat@gmail.com Assigned to: David
Priority: normal Milestone:
Component: ActiveRecord Version: 1.0.0
Severity: normal Keywords:
Cc:

Description

quote_column_name returns incorrect quoting for a column name if the name contains a backtick. It's not serious, since nobody in their right mind would do that, but it doesn't hurt to take it into account. passes all unit tests with patch applied

Attachments

mysql_quote_column.diff (447 bytes) - added by JohnDouthat@gmail.com on 01/02/06 07:00:34.
patch

Change History

01/02/06 07:00:34 changed by JohnDouthat@gmail.com

  • attachment mysql_quote_column.diff added.

patch

01/02/06 07:00:51 changed by anonymous

  • summary changed from mysql adapter incorrectly quotes column names containing a backtick to [PATCH] mysql adapter incorrectly quotes column names containing a backtick.

01/13/06 02:35:36 changed by marcel

  • status changed from new to closed.
  • resolution set to wontfix.

Thanks for preparing a patch. I say this is Too Much Software. Creating a column with a backtick sounds like a major edge case that does not justify complicating the code.