[PATCH] Logger/ActiveSupport broken with Ruby 1.8.3?

Patch to check before trying to remove a non-existant constant Format

Upping priority

Yeah let's get the Namespace right this time Schubert :-)

Well according to David Black and ruby-lang Logger::Format is now Logger::Formatter::Format ... This is probably a bigger issue than just a simple patch.

I'm sorry about the spam mathieu, for some bloody reason safari feels like it should auto-fill in the Cc field in tracks for me by copying the data from a previous bug.

Please use Logger#formatter= if defined such as;

logger.formatter = proc { |severity, timestamp, progname, msg| "#{msg}\n" }

you can just call Logger#<< if you don't need level filtering;

logger << "#{msg}\n"

Actually here's an even simpler implementation that works in both:

    def format_message(severity, timestamp, msg, progname)
      "#{msg}\n"
    end

We can't use logger.formatter= since that would require changes for each instance and logger << would require changes in the calls.

Why don't you implement new logger class by yourself? (as a wrapper of Logger or a new class) Overwriting existing definition is considered harmful even if you can do it in Ruby.

That's also a good idea nakahiro. The logging in Rails could definitely use some additional love. I know clean_logger is rude.

I was using the format_message method and found that the order of the parameters was switched. I'm on Ruby 1.8.4 / Ror 1.1.2

    def format_message(severity, timestamp, progname, msg)
      "#{msg}\n"
    end

and it provided the formatting control I expected.