Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #2064 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

[PATCH] Allow subversion interaction with code generators

Reported by: kevinclark Assigned to: David
Priority: normal Milestone:
Component: Railties Version: 0.13.1
Severity: normal Keywords: subversion generator
Cc:

Description

Currently if you use the code generators then you must manually add and remove the files from subversion. This can be a problem when there are many files and svn add ignores svn:ignore. My patch adds interaction with a subversion repository (add and destroy) with a flag (-c, --svn).

As an added bonus, I foudn that it looks like Rails::Generator::Commands::Destroy#file would overwrite options in its scope, which made it impossible to do -p (pretend) with the destroy script. I fixed the bug.

Attachments

svn_support_for_generators.diff (3.8 kB) - added by kevinclark on 08/27/05 16:39:30.
Adds svn support to code generators.
svn_support_for_generators.2.diff (3.8 kB) - added by kevinclark on 08/31/05 03:39:35.
v2 patch

Change History

08/27/05 16:39:30 changed by kevinclark

  • attachment svn_support_for_generators.diff added.

Adds svn support to code generators.

08/29/05 15:04:43 changed by anonymous

  • summary changed from [PATCH] Allow subversion interaction with code generators to [XPATCH] Allow subversion interaction with code generators.

Found bugs when working with externals.

08/31/05 03:38:35 changed by anonymous

  • summary changed from [XPATCH] Allow subversion interaction with code generators to [PATCH] Allow subversion interaction with code generators.

Added a check to make sure that we're getting pairs to turn into a hash. I'm only doing this by checking to make sure there's two elements per line given to the hash, but even if its not a modification-file pair, we're only using it to check for modifications on files we play with in the generator and extra fluf in our hash won't hurt anything.

08/31/05 03:39:35 changed by kevinclark

  • attachment svn_support_for_generators.2.diff added.

v2 patch

08/31/05 03:40:06 changed by anonymous

The anons were me btw.

09/09/05 09:02:56 changed by david

  • status changed from new to closed.
  • resolution set to fixed.

09/09/05 10:29:58 changed by anonymous

  • status changed from closed to reopened.
  • resolution deleted.

There are a couple of typos in this patch that got applied to svn. The word delete is missing the 'd'.

09/11/05 06:26:56 changed by david

  • status changed from reopened to closed.
  • resolution set to fixed.

These were also missing in the original patch. Fixed, though.